From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ca1d:0:0:0:0:0 with SMTP id a29csp3907788lfg; Mon, 28 Jun 2021 04:32:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFT17xtUXFsKKhA4oYMDhaJ6m5heGcZibvmc53bDMdE7vaZu+TjaLTDXZdjIgZ1EM06dgp X-Received: by 2002:a25:60c1:: with SMTP id u184mr30005125ybb.343.1624879967299; Mon, 28 Jun 2021 04:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1624879967; cv=none; d=google.com; s=arc-20160816; b=lX0VQF1qbA1KpICKs9clnZ2bW0fWjTHYAmU6mRcafUcviUu00aEaeqeFD4HuoPyaH7 LUZ2CdclSbEFqiGX4/+/vtRekfUAzI0yHb/eTktqjrENyhZZ+3Nuida8KLSxcAmQUfny xYKhpl9bK9r1LiwA5MRtuBVqD05jCK9RlJUAKd9AAqyl6Tz1hUvLfJWf6fneUf/6JaSo 9lYsc450MCsSfLSM/tJr3MEc0hlVtaiDQH2ZsraQMD0urC5EETSY6z13h7HEQwoAOk4A xDmiA4d4b8dUtszLN+A+yp6cd7jPD2K4IcnA9DrLVDDMYit+G51VjBpJQJBzp63S5/r2 wRzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:content-disposition:user-agent :in-reply-to:mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=Xdi8Wn2/gUuwEca2TWSt1v/uH6X0Th+LRRyoxc6Rn4U=; b=wsDZH1hTx2uCEcWSPaLb6VavC1OH0tNx+5dYM87MtD3oAAQK2EyJkDm6seSHAACjhM kQSLFtUTIHR4M3MZu6XFbrzXRfUOdg9THNpLBp9IEc6VqnxBdH2afTucaaQw47rHTM5k O/EHJy8CsL3vUB/OQzyZ0gVBVbJUoZy4MJ8Xu5cVgjtE9iSN/OIuw5PWYBGNTHvC7dyI 1oQOwSJyqVtgOWAuuipWyYlUQVSUmw0hP8Afo/yloSauUWm233Jrzgm86A8v3NFVPBMx 1rfxt9IMjTsxAIYZWvbbeAsEbaBBt86nA+L/rGBodrhqTaJRVYWElUAX8R6OeIFtXy6t hpeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=NwHrO+y0; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s4si14362650ybc.151.2021.06.28.04.32.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jun 2021 04:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=NwHrO+y0; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:52802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxpVO-0003i8-K4 for alex.bennee@linaro.org; Mon, 28 Jun 2021 07:32:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxpV6-0003gH-Dn for qemu-arm@nongnu.org; Mon, 28 Jun 2021 07:32:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxpV2-0001T9-LV for qemu-arm@nongnu.org; Mon, 28 Jun 2021 07:32:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624879944; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xdi8Wn2/gUuwEca2TWSt1v/uH6X0Th+LRRyoxc6Rn4U=; b=NwHrO+y03L9/mq2BcCgbeo9E5QmQ+x18APjT1UFRkQLl4qUre7AgDe/0fBIxaeLEFAJKyj 3lyh6zGe3hIsdcHywPGxyBFxpyt9l8AKXW9deQJP7+PuxEBok95AyLto6aLpPryeXiFcsj NyZ9nt/1zPgJ0Bdd8kGjUe9nL+fmB3s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418--frHanaTPyCqHUqQ4E8b4Q-1; Mon, 28 Jun 2021 07:32:10 -0400 X-MC-Unique: -frHanaTPyCqHUqQ4E8b4Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD4C919057A0; Mon, 28 Jun 2021 11:32:07 +0000 (UTC) Received: from redhat.com (ovpn-115-35.ams2.redhat.com [10.36.115.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22EE65D9CA; Mon, 28 Jun 2021 11:31:59 +0000 (UTC) Date: Mon, 28 Jun 2021 12:31:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "wangyanan (Y)" Subject: Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support Message-ID: References: <20210622093413.13360-1-wangyanan55@huawei.com> <20210622114634.crjqusw6x6oj4j6v@gator> <7fcc5f2d-cc84-3464-15cc-3bebb07f8190@huawei.com> <909af1cb-7e7b-7532-06b5-69cd9487e001@huawei.com> MIME-Version: 1.0 In-Reply-To: <909af1cb-7e7b-7532-06b5-69cd9487e001@huawei.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.375, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Barry Song , Peter Maydell , Andrew Jones , Paolo Bonzini , "Michael S . Tsirkin" , QEMU Developers , Shannon Zhao , Igor Mammedov , qemu-arm , Alistair Francis , "Zengtao \(B\)" , yangyicong@huawei.com, Zenghui Yu , wanghaibin.wang@huawei.com, Keqian Zhu , David Gibson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 0CFGBMxe7D6j On Mon, Jun 28, 2021 at 07:14:02PM +0800, wangyanan (Y) wrote: > Hi Daniel, > > On 2021/6/22 22:28, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 03:15:18PM +0100, Peter Maydell wrote: > > > On Tue, 22 Jun 2021 at 15:11, Daniel P. Berrangé wrote: > > > > The QEMU man page says this explicitly > > > > > > > > For the PC target, the number of cores per die, the > > > > number of threads per cores, the number of dies per packages and the > > > > total number of sockets can be specified. Missing values will be > > > > computed. If any on the three values is given, the total number of > > > > CPUs n can be omitted. > > > Anybody feel like submitting a patch to fix the typo? Should read > > > "If any of"... > > Actually looking at the broader text for -smp, the whole thing just needs > > to be rewritten from scratch IMHO. I'll send a patch.... > Do you have any plan to rewrite the -smp text in qemu-options.hx recently? > > I suggest that we explain in more detail how the missing values will > be computed, so that qemu users can have a clear image of what a > -smp parameter collection would be parsed out if they are using an > incomplete cmdline and have read the man page. > > Also if we all agree to prefer cores over sockets for all arches since > machine type 6.2, I'll be glad to add this change for the man page > and update the parsing helpers in next version of this patch series. I wrote a docs update on friday, which I've just sent out as a short patch series with yourself CC'd. I wrote it such that we can easily update it again, if we want to prefer cores over sockets. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|