From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e348:0:0:0:0:0 with SMTP id c8csp2392744lfk; Mon, 25 Apr 2022 06:41:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydJY0fNjSakU9li07BwI4dW4hOWpv1cc9VD+56eOIfALHXKpJUdSIZGgenuJvpPk8FdHD5 X-Received: by 2002:a25:7e83:0:b0:645:4aaa:3e28 with SMTP id z125-20020a257e83000000b006454aaa3e28mr15434799ybc.284.1650894097386; Mon, 25 Apr 2022 06:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650894097; cv=none; d=google.com; s=arc-20160816; b=O/S13rVU1RqjNg8UPAoEdGf8ui/DbvFYlC1RiYjGEItqo7kh5pQKVmjDn2HZUvTmwz qBgLzi0+gvnW8mB5Fh9bh4rmxz/6nQiTr9DxGEusr71ceqbEmnfPmm3yj2lFlZ3d7plw xkcpcAGZ8orkvfBho15QJnmxn8kbywNDYddo8nh3CRFBdhQrvunbwBQlGb/2EXMSk+Y7 J5u+OHzkd6D8OUb6S7uXVsI0bMw62ASHCYNIP4CzZ+T0i2RFok6J7TQUMXvLhpvICIz0 NAk8qZ3YTPJq8tAR8j/8N1LllMawGhvCuVylThNuCeUOF2VBSBhz2le3I87MLi343D1h EeBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:dkim-signature; bh=pedaxoCU72iT7NEZVSntcaqcBblU2iePGz5jjDkgT8I=; b=sL/+mwk1+NcTszJEHI3ojfECQ48t7wFrQ9p5jqcUO2Rqn5qskC3CA6C2rmBrYFM5XW d6/qv9OlzFDpN+RfwAoUoO9mKFQHARrHQgTuwTODkwk98XiGgrOkd7xOPdJGjOp9cN93 DY4SlRReOWcphrKX5t1DEZAgm77JZvwWJD1LHgBOaHAQTp4rfYLiOWk6TG+/D3Opixbm MZTgtqVLW8YTXtknyn+OecC+tUSB+7euoiQDiylDoP4lPygDsh5W2pvmMocuVGINDbFA SQ8DgeRKYPUOBaSD7CAU/P535S2d2eFX3IhdMhs7/xDqkk+/Yf64W7oh1fJRmBh/X9Cn yzug== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=ROocdiiX; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g83-20020a252056000000b00633994043ccsi11846339ybg.54.2022.04.25.06.41.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Apr 2022 06:41:37 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=ROocdiiX; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:57130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niyy8-0000HX-Qj for alex.bennee@linaro.org; Mon, 25 Apr 2022 09:41:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niyrB-000089-Nw for qemu-arm@nongnu.org; Mon, 25 Apr 2022 09:34:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niyr7-0004gL-3C for qemu-arm@nongnu.org; Mon, 25 Apr 2022 09:34:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650893659; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=pedaxoCU72iT7NEZVSntcaqcBblU2iePGz5jjDkgT8I=; b=ROocdiiXqinSgEyGWe7iCJ4k74rizA3JeuDazAt6n+prZJGBK3YDp6CphIyGZ7d/jlMOCx zkj3m5LulQKiVA3/gFOpUAGnbCEJhy/dQVj8otHa7AhvlsXCx00NG1FrrmAhBQsCXlqNZ8 qQAZbME428IumpprodTOUD22QYY1FQw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-604-A_BUruE-NZSIvs9Ni2m0wA-1; Mon, 25 Apr 2022 09:34:16 -0400 X-MC-Unique: A_BUruE-NZSIvs9Ni2m0wA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A99AC185A7A4; Mon, 25 Apr 2022 13:34:15 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7342840CF8F5; Mon, 25 Apr 2022 13:34:11 +0000 (UTC) Date: Mon, 25 Apr 2022 14:34:08 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Martin Kletzander Subject: Re: [PATCH 13/18] audio: Make AUD_register_card fallible and require audiodev= Message-ID: References: <92b31c6af268b8f2a4cc4ed5b20ee8d0e19f614d.1650874791.git.mkletzan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <92b31c6af268b8f2a4cc4ed5b20ee8d0e19f614d.1650874791.git.mkletzan@redhat.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Pavel Dovgalyuk , libvir-list@redhat.com, Christian Schoenebeck , qemu-devel@nongnu.org, Yanan Wang , Gerd Hoffmann , Qiuhao Li , =?utf-8?B?SGVydsOp?= Poussineau , Marcel Apfelbaum , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Laurent Vivier , Thomas Huth , Alistair Francis , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, Jan Kiszka , Stefan Hajnoczi , Eduardo Habkost , Darren Kenny , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 3dVAI7AK10nN On Mon, Apr 25, 2022 at 10:21:56AM +0200, Martin Kletzander wrote: > Now that all callers support error reporting with errp and all machine-default > devices use an explicit audiodev, this can be changed. To make the detection > easier make AUD_register_card() return false on error. > > Signed-off-by: Martin Kletzander > --- > audio/audio.c | 7 +++++-- > audio/audio.h | 2 +- > hw/arm/omap2.c | 3 ++- > hw/audio/ac97.c | 6 +++++- > hw/audio/adlib.c | 7 +++++-- > hw/audio/cs4231a.c | 6 ++++-- > hw/audio/es1370.c | 5 ++++- > hw/audio/gus.c | 4 +++- > hw/audio/hda-codec.c | 5 ++++- > hw/audio/lm4549.c | 4 +++- > hw/audio/pcspk.c | 4 +++- > hw/audio/sb16.c | 6 ++++-- > hw/audio/wm8750.c | 5 ++++- > hw/display/xlnx_dp.c | 6 ++++-- > hw/input/tsc210x.c | 3 ++- > hw/usb/dev-audio.c | 5 ++++- > 16 files changed, 57 insertions(+), 21 deletions(-) > > diff --git a/audio/audio.c b/audio/audio.c > index 671845c65d18..b95aca444382 100644 > --- a/audio/audio.c > +++ b/audio/audio.c > @@ -1822,15 +1822,18 @@ void audio_free_audiodev_list(AudiodevListHead *head) > } > } > > -void AUD_register_card (const char *name, QEMUSoundCard *card) > +bool AUD_register_card (const char *name, QEMUSoundCard *card, Error **errp) > { > if (!card->state) { > - card->state = audio_init(NULL, name); > + error_setg(errp, "No audiodev specified for %s", name); > + return false; > } This is a significant change in semantics. qemu-system-x86_64 -device ac97 will currently automatically create a default audio backend for the user, but now it just reports an error. I don't think we want todo this, as allowing 'audiodev' to be optional was an intentionale thing to be more user friendly to casual userss. It lets command line args they use "just work" regardless of which audio subsystem their host OS happens to be using, which wouldn't be the case if we force them to use -audiodev every time. > > card->name = g_strdup (name); > memset (&card->entries, 0, sizeof (card->entries)); > QLIST_INSERT_HEAD(&card->state->card_head, card, entries); > + > + return true; > } With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|