From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e348:0:0:0:0:0 with SMTP id c8csp2394019lfk; Mon, 25 Apr 2022 06:43:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ1FJN8rd4ji2gj39+7WuoNf1MPNxZ3NDpZuhAY2Q1jUwLArlG90G/AKMIXoGKYhcH1Zbp X-Received: by 2002:a05:6902:2cf:b0:648:4029:ab1b with SMTP id w15-20020a05690202cf00b006484029ab1bmr8416877ybh.60.1650894216658; Mon, 25 Apr 2022 06:43:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650894216; cv=none; d=google.com; s=arc-20160816; b=A1qYh2iiJ7FDQR1t/P4mERaQTZ+hb0aZ3yFRPYiVFkz7GK8+ZyyR1QeYXWFpY+2xej N4pnpFNROHE6O+I356EgL8bPVFRBtl8IEmfIkofiOq2jnyYCmsmL2dXNY1j9YCXFAxVN TA0VTmJ2tZ6QH8lvCW1aVmILKQ+ftUZXreXq/kJy/Tj5/qOuEGYjbKVp5AaTFzPexpkf bawcH/HIqVcszIodeA4BUb3kCyIx7K/iCtzp7zF4Wdf55Jo3iKFygsvVxAXG3Oa+tdiT G+dStv6fm146nSX/gGrTJYctQ1BwrdBVQ5lPT5B4WkVfCq7d9A+u5bq0Y3wRfd97m2Fm /m9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:dkim-signature; bh=WbNUh1I3jnfhyYa6Yds+ehnMZ1SLgNxHI5V/atzr5qU=; b=QEKVBpUZPYZaMhwqSCJ5z3FjMa85tXX2o+jTmuB+lA7Vl6ytdhj1WbyW67+sFxC6rt TIUPkWQHIcMwEQXJrLwAm1fXKrxO6WSSRCRFlstd7hHwGH7bSXnCzwCNkgdabctziPJa A4avh5SGdqJGqD+gGATHWn72EbsXJasyUqY6nVtHkp/9XBearvM8pW5JI6TZ5ni5+XEm i5qhRe29E6MIqgBXIqUqlY4rg4D6DgTIyA6rpzjbpnKu6f2dtKtURdoMRXERBG8eG1bc Jdiqu2mnr5tgbdfjJT6HUwpj53Szff2k2nVTQcY5jtP3s555lyTWVfDGSbPCQha2cGdI 3w8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=bAKUZrHh; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id z130-20020a256588000000b006483d18b883si5247956ybb.25.2022.04.25.06.43.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Apr 2022 06:43:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=bAKUZrHh; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:59776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niz04-0002Cz-1x for alex.bennee@linaro.org; Mon, 25 Apr 2022 09:43:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niys5-0001RI-9C for qemu-devel@nongnu.org; Mon, 25 Apr 2022 09:35:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:48725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niys0-0004zB-Ix for qemu-devel@nongnu.org; Mon, 25 Apr 2022 09:35:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650893714; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=WbNUh1I3jnfhyYa6Yds+ehnMZ1SLgNxHI5V/atzr5qU=; b=bAKUZrHhkXn0PIST2b5Xe3i9AeAcOdq7QYsHLMv01uNHCuU3XrA5odcZ7gGNuGg3R8KGX0 ZuIDwVipBVPCluRQwzexghn7HCYiel/L5IJ/fpbCxgQOzuX6po5ZtqRP9j+OkNpgnXdJXb wM9pG/IfY2TnIXWUx8S4rv9PpdGCPG0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-313-Pyf9RvlINDiJCsa2fzZ7GQ-1; Mon, 25 Apr 2022 09:35:13 -0400 X-MC-Unique: Pyf9RvlINDiJCsa2fzZ7GQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5E081800B28; Mon, 25 Apr 2022 13:35:11 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAAE74047D3D; Mon, 25 Apr 2022 13:35:07 +0000 (UTC) Date: Mon, 25 Apr 2022 14:35:03 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Martin Kletzander Subject: Re: [PATCH 03/18] hw/audio: Simplify hda audio init Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Pavel Dovgalyuk , libvir-list@redhat.com, Christian Schoenebeck , qemu-devel@nongnu.org, Yanan Wang , Gerd Hoffmann , "Edgar E. Iglesias" , Qiuhao Li , =?utf-8?B?SGVydsOp?= Poussineau , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Laurent Vivier , Thomas Huth , Alistair Francis , Alexander Bulekov , Bandan Das , qemu-arm@nongnu.org, Jan Kiszka , Stefan Hajnoczi , Eduardo Habkost , Darren Kenny , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: fy8Z7gzbClaM On Mon, Apr 25, 2022 at 10:21:46AM +0200, Martin Kletzander wrote: > No return values are used anywhere, so switch the functions to be void > and add support for error reporting using errp for use in next patches. Making it 'void' makes sense, but I'm not sure we need the Error **errp addition, given my comment on patch #13. > > Signed-off-by: Martin Kletzander > --- > hw/audio/hda-codec.c | 32 ++++++++++++++++++-------------- > hw/audio/intel-hda.c | 4 +--- > hw/audio/intel-hda.h | 2 +- > 3 files changed, 20 insertions(+), 18 deletions(-) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|