From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:4c26:0:0:0:0:0 with SMTP id u6csp5260579lfq; Wed, 30 Sep 2020 00:08:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqCYlRQBz1Kko1SuVky9LJm6icecGPCiGyuL4/SyyBUOKKgi2FZpibfyRzKSnYJWCZ3tUr X-Received: by 2002:a17:906:564d:: with SMTP id v13mr1470022ejr.217.1601449715302; Wed, 30 Sep 2020 00:08:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1601449715; cv=none; d=google.com; s=arc-20160816; b=HTE3dqejUhb7KMubL1SSioNS87M0EaozW56B74gVBnpAGhLr25X4F/UXB8RTcvMbrN XFcI1Yjj4qHFecpBK229TEn5d05GbOAWJxUomb9c0R9BFkzJ6Y0sMn3bFOgm3GZLxz+i yqe4Etu76zCbhybQzo1fWXL5ohyguX7TbrrHwpDvA6N5mpsYN7gj2ilxC0kkKCAIXIBU Lnqjk04oHZ/4Ueu198g8ivu+Vy10n0ixjlv/5Qsig7PGbSOUqiIRS+hhvT9GDXoXyV2k Gle0Fe29L+SoxN6vqhW9i3UrCxpRZ3opTBfCuYvUPbIM3K4F9ZQ6bkMxyQWmPq1JgIzZ phtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=7kUs5d+Zsd2wY/LnTcUI6w/pXXOgggi3joJfi847hNg=; b=sA2VKZ/ywg4yYmcyTzDEOoIiNamZa/Js9P+S5bMHdIZrJITg31JpQyGQAboPQnw1PD oaqjDOYLzDBz4C32MqUxEnx4QnoVRBaaOaN7mKLLB30CZzdVauCU7kCUXH3mmzpH6sXt aPwy6jmBppQmKZoI3xZYFA0TGM7SI68Ci620kGQZtSqiaez2x/HIpy4QwiQXlTIc3jf8 CZ4smveOq8/i934FRh11wxP0jtast/1CIhcjkwIKiWXI2BQL9TFL0qFMwytWWCFHWYxz Gl1WcydmHvZueEb6/77z7+At59wDULUu5EM9a/0ZTszy+IHMG08MGMU3pTtNJDs5VAIp wRQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WGjQ0Lsv; spf=pass (google.com: domain of thuth@redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=thuth@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [216.205.24.124]) by mx.google.com with ESMTPS id y22si713717ejc.738.2020.09.30.00.08.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Sep 2020 00:08:35 -0700 (PDT) Received-SPF: pass (google.com: domain of thuth@redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WGjQ0Lsv; spf=pass (google.com: domain of thuth@redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=thuth@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601449714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7kUs5d+Zsd2wY/LnTcUI6w/pXXOgggi3joJfi847hNg=; b=WGjQ0LsvgfFkPXwNX4P3+mwb6W8YVBkzs/zbkSWuplvbpkPWT7006lw7n106bUHOWNN0EB qFJhyZu+fBJVAoJC+QsFOd8g46+6uw9dtbY6qLCittMiMX28SqsHgGbnlUoDHZdT+E/X1h 1E7l36hi/hFD6UsuUXv3rzajAT69wbM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-e6i0tfBfOgCcVxw46at20Q-1; Wed, 30 Sep 2020 03:08:30 -0400 X-MC-Unique: e6i0tfBfOgCcVxw46at20Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9EBD51005E64; Wed, 30 Sep 2020 07:08:28 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-148.ams2.redhat.com [10.36.112.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 34D5473678; Wed, 30 Sep 2020 07:08:25 +0000 (UTC) Subject: Re: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , Richard Henderson , Fam Zheng , Peter Maydell , kvm@vger.kernel.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-arm@nongnu.org, Richard Henderson , Keith Packard References: <20200929224355.1224017-1-philmd@redhat.com> <20200929224355.1224017-2-philmd@redhat.com> From: Thomas Huth Message-ID: Date: Wed, 30 Sep 2020 09:08:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200929224355.1224017-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-TUID: 7CXunJ8zx1Fa On 30/09/2020 00.43, Philippe Mathieu-Daudé wrote: > Since the support of SYS_READC in commit 8de702cb67 the > semihosting code is strongly depedent of the TCG accelerator > via a call to cpu_loop_exit(). > > Ideally we would only build semihosting support when TCG > is available, but unfortunately this is not trivial because > semihosting is used by many targets in different configurations. > For now add a simple stub to avoid link failure when building > with --disable-tcg: > > hw/semihosting/console.c:160: undefined reference to `cpu_loop_exit' > > Cc: Keith Packard > Signed-off-by: Philippe Mathieu-Daudé > --- > accel/stubs/tcg-stub.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c > index e4bbf997aa..1eec7fb90e 100644 > --- a/accel/stubs/tcg-stub.c > +++ b/accel/stubs/tcg-stub.c > @@ -29,3 +29,8 @@ void *probe_access(CPUArchState *env, target_ulong addr, int size, > /* Handled by hardware accelerator. */ > g_assert_not_reached(); > } > + > +void cpu_loop_exit(CPUState *cpu) > +{ > + g_assert_not_reached(); > +} > Reviewed-by: Thomas Huth