From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:907:9874:b0:a31:23a7:2a34 with SMTP id ko20csp779840ejc; Fri, 26 Jan 2024 02:15:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFesspAj9qXbCHoF4QNz0qxCR//TFZkk6OX/mxY1Y6IfXBOnzQXdqf7Jg8+f33Ylez1uFti X-Received: by 2002:a05:620a:4110:b0:783:de24:f315 with SMTP id j16-20020a05620a411000b00783de24f315mr11164qko.58.1706264108794; Fri, 26 Jan 2024 02:15:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706264108; cv=none; d=google.com; s=arc-20160816; b=wO9x2/kHeLJY19VMzLRmDAKn8oP0X13/7eN8hfTF3q30iuZVkphzumKaZfyEYu5A4f loSq7gRTPpwX3z0OCn4v4wI9D2RMETEdufptDXqJKcPDZ7FYxPypJHvpehY5yqTq9Q+e w/uVFeUD/qY5KVGoW2gB8C/+zRt+1rSQJBRpJcGsxgybg/7+5MbGoAIBcQJfa+utQDQd kPtHvzQDXhSnTgqW6x9D03L8mDV2ZoP/xPLES90CNI4AnZli9evQs/1WWDkyakT8Xl2S FUvyIyuhznT6gbFytzXJ9wsto2IJ90P5ub7cnoxRrXpmuV1kqDUyHBFEgEp+zD1QIseO z04g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=jhBDrfCPc0nvPf8IzQcTnXzADIYobhAH5Tm0bTyLM/k=; fh=HTHR+Q2d6bLhEl37Oh4T8uXQP5/6sUv4T2u8Op+j0Ns=; b=MwqpUEEHl8ygM/F5ILzs1QAV2jXmynfjXBaPZa/wNKA8/A7lb97kBmfT43MUmLngqe Pko80VuqFskg7AVqmJZ9yrtlBtS8U2jyZoyz4jE0GxnycLQwj/jOgTNWIWhcSksw35Ek oKkPDNp1zqLDFWg6yYRAz+lMd6S0R7G/GwXhviL9P29qJXLm/9ARkuc2fIX8U2e3IFc5 OpgJVUCXXNY9CEaqNIdWpPwbMfUtbg4nosQMrrhOoZPkgQWH3Hw7LHSXU2WCgDVK77YA b/Tx2TDVVTe0p+v46wPOKqMrXw7wyZe7TyezgkwLD4GA1ba25CX3WRvbrSMW90kLTl2L VTpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=jZ8Eb+FJ; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y21-20020a05620a09d500b0078399655a4csi995184qky.376.2024.01.26.02.15.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jan 2024 02:15:08 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=jZ8Eb+FJ; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTJEl-0006BM-KJ; Fri, 26 Jan 2024 05:15:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTJEj-0006AS-7x; Fri, 26 Jan 2024 05:15:01 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTJEh-0006Il-Lk; Fri, 26 Jan 2024 05:15:01 -0500 Received: from pps.filterd (m0353722.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40Q85rGY006758; Fri, 26 Jan 2024 10:14:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=jhBDrfCPc0nvPf8IzQcTnXzADIYobhAH5Tm0bTyLM/k=; b=jZ8Eb+FJPcyB4cwy0MrbkZK4oEQhj9bLzmvqTkPW39xfxjYnhRgSw9Ui4KGgZ4DcSq1D KoeGQ7cXMPkA6JXLs58haRbaHbFIobVwIDmNwBAkufY5J8u8WONAgkGKNfx2PT/4ERl5 QfLSOU7hPPwpN8IOup6fxmLsN3/N/FAEC+BY6gH/k2vh3zldYo/+CD2rY81RolR0SCnb wh++dk9CvmHTr0aM7ZOG+UEHc3vRtApcbpD2nwGq16s6TW31JqmU1JHpV+diqShYXWpc c3vG8moJB5BT4HvmjOm2T76SbqrQforl4ONmHEvBVKOv9qfKVpEaY6gLIMht1lO17Rnr PQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vv89susrd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 10:14:42 +0000 Received: from m0353722.ppops.net (m0353722.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40Q9koxl002070; Fri, 26 Jan 2024 10:14:42 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vv89susr5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 10:14:42 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40Q901M6022510; Fri, 26 Jan 2024 10:14:41 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vrt0mhxkt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Jan 2024 10:14:41 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40QAEe7x15991334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Jan 2024 10:14:40 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 530E05805C; Fri, 26 Jan 2024 10:14:40 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9AF5E58054; Fri, 26 Jan 2024 10:14:39 +0000 (GMT) Received: from [9.61.160.70] (unknown [9.61.160.70]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 26 Jan 2024 10:14:39 +0000 (GMT) Message-ID: Date: Fri, 26 Jan 2024 04:14:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus Content-Language: en-US To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, peter.maydell@linaro.org, andrew@codeconstruct.com.au, joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, thuth@redhat.com, philmd@linaro.org, lvivier@redhat.com Cc: qemu-arm@nongnu.org, Andrew Jeffery References: <20240126034026.31068-1-ninad@linux.ibm.com> <20240126034026.31068-8-ninad@linux.ibm.com> <2e705ae9-150b-4a35-a7ae-660577aab263@kaod.org> From: Ninad Palsule In-Reply-To: <2e705ae9-150b-4a35-a7ae-660577aab263@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: mMyfOwGxz6OSW356bklE6QJyhJogsHY9 X-Proofpoint-ORIG-GUID: DyrA6d4ObRpDqpeJSvn3Z-cI4sTmKLOx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_14,2024-01-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 mlxlogscore=782 priorityscore=1501 phishscore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401260074 Received-SPF: pass client-ip=148.163.158.5; envelope-from=ninad@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: jYFzgFpRS4sD Hello Cedric, >> + >> +static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp) >> +{ >> +    SysBusDevice *sbd = SYS_BUS_DEVICE(dev); >> +    AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev); >> +    int i; >> + > > Please add a comment regarding the OPBus model here, something like : > > /* >  * TODO: The OPBus model initializes the OPB address space in >  * the .instance_init handler and this is problematic for test >  * device-introspect-test. To avoid a memory corruption and a QEMU >  * crash, qbus_init() should be called from realize(). Something to >  * improve. Possibly, OPBus could also be removed. >  */ Added comment. > > with that, > > > Reviewed-by: Cédric Le Goater Added tag. Thanks for the review. Regards, Ninad