From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F735CA1010 for ; Wed, 3 Sep 2025 12:47:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utmst-0003JI-K9; Wed, 03 Sep 2025 08:46:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utmsp-0003IP-3s for qemu-arm@nongnu.org; Wed, 03 Sep 2025 08:46:39 -0400 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1utmsm-0008Pw-TN for qemu-arm@nongnu.org; Wed, 03 Sep 2025 08:46:38 -0400 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-61cf8280f02so7664110a12.0 for ; Wed, 03 Sep 2025 05:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756903595; x=1757508395; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uiEPZYL3P5yfCnyWgxr/DplYOOXT+KOSq8kuFS9sW+c=; b=WdvzxC2AyA1xGLikak6Lt0woJZb+YaqyVWXHpEk3jq9WdgmD7q6JGaUGJb/PCWgUv3 1Bgl/gUVLmAQR/1r4JPv90mAwMaJpzBRNLfrGICqbXUdlUoao6g9OHPy31zsw9PqwJj+ /KvJ4ophN/B1U25C2AMKKnDzMTWU6MA2a24WirGfg9p+AfQv1zi6Ah0SQKpZTp15TkzG vysmYF5Kwqu7fmw3t01dRLT/UVhm1hlpcLVYVqXZymGyyGiufStLnRh/R1dtF44J9mCH qU5IOdWdQ3ia6lqc5vGrfDqjUH9xPVj5pNGHqjtJ7zZ5RL6k+R+xeCzCgu4WFhHn9Hmb uDMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756903595; x=1757508395; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uiEPZYL3P5yfCnyWgxr/DplYOOXT+KOSq8kuFS9sW+c=; b=xBKkzjUJhBGDbWbTais9zW9PlmaibLqJBzisY48lH0eAD01SNKFSUbzBIaESJgWHVf I9TNyY6hlhAgALkJAiix7q9rI7IhQLjdlEI8mM6BEY0v2RkDdD0oqWmuqsc8hg6C+jh9 nBEs4fbZt8BdhDUDodSaYrbT9sl9+o1stwyzOkhjWnQYWz4Kyp1LOudsHl0RMG6qMBOT IIF4EJsjPRKUkxgQAUiH6FvVfMiX8SS31OAl6nXzdL2/zNOk9KZp0/L37AzkwiZ7bN0X ZxnhTIWyCdzUTcCzsUMb2ERVDaZBL+CV37g9Wg24wkmUHKhK3cOAYqdzc7xQGvDHvTKU hLCQ== X-Forwarded-Encrypted: i=1; AJvYcCWOFJ/yAyyBBZGdLf77mHligOO9Mk9OI6s0OqAOReXDKq2pU6R+HD0j8x6nOu5DG4zZ/OO0Cdc4ug==@nongnu.org X-Gm-Message-State: AOJu0YzpDcebpn7UHuR8ixIDkWs5sbxSKZJHb7fV4pC3WH0dgzCnGRnZ bWJmYaHM3JgqmgXYp/avdppC4B8cOV0X/+MdSCH2yLo/Zlm70nTrnzcv/QyqGlgYx5U= X-Gm-Gg: ASbGncsuYHE07prOR3lUhq8cN0ggUtzIAdduaWzxvAcjfw/BVOiyY981tzBHPJgxPMO fKOt/XvyaLdwh7LRvZwQR5CMyO5sSecWzs8g84lkapX53lRwKaslGzRKvu6FxEppC4m1v22bjX4 ErGZQGSJi6ZAszhrpxFztK0QbQ/MarA4Wh94P9wKtGu4tCL7QmUIGXI5irK7P0PeEN9+RRt3OiV rHB/ZlNNoE3WwJbuzsQkug9YHp+8YmMRKzI9n6p/mGAwYXYMj16OGXGz5RdYfuypE4TmVUJpcUS 6WEb4TJjlwi4w4CLm6MkUPOZxUF9jQ+S8V7ZCU8lZqSYtXmbPEwpnutaYW7O5EusSvlXi+KEO+q pyPY13pVe7UvaAt+iy+DvWkwLW6i2z7Ts8gST1yCA7kD3RMAQHOQx3RNlteOTM9E9Oh8s4a5vO6 DCLdVlzg== X-Google-Smtp-Source: AGHT+IEi+V9LPxqnLn+jGHDZGr1XZHAxrhKBmRxRpdm2kmDUPWTkdnUxpP6VmrtVKgTZpuobGH9k0Q== X-Received: by 2002:a05:6402:84e:b0:61a:9385:c78b with SMTP id 4fb4d7f45d1cf-61d26ecf561mr12776206a12.38.1756903594735; Wed, 03 Sep 2025 05:46:34 -0700 (PDT) Received: from [10.40.6.207] (93-51-222-138.ip268.fastwebnet.it. [93.51.222.138]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61cfc4e5229sm11814625a12.39.2025.09.03.05.46.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Sep 2025 05:46:34 -0700 (PDT) Message-ID: Date: Wed, 3 Sep 2025 14:46:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/24] target/arm/hvf: Factor hvf_handle_exception() out To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Alexander Graf , qemu-arm@nongnu.org, Mohamed Mediouni , Peter Maydell , Mads Ynddal , Phil Dennis-Jordan , Stefan Hajnoczi , Cameron Esfahani , Roman Bolshakov , Paolo Bonzini References: <20250903100702.16726-1-philmd@linaro.org> <20250903100702.16726-17-philmd@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250903100702.16726-17-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::536; envelope-from=richard.henderson@linaro.org; helo=mail-ed1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 9/3/25 12:06, Philippe Mathieu-Daudé wrote: > +/* Must be called by the owning thread */ How could it not? > +static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp) > { > ARMCPU *arm_cpu = ARM_CPU(cpu); ... > +int hvf_arch_vcpu_exec(CPUState *cpu) > +{ > + ARMCPU *arm_cpu = ARM_CPU(cpu); Don't dynamic cast twice. Pass down the ARMCPU, or use env_archcpu(cpu_env(cpu)). r~