From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39DF9CA0FF2 for ; Wed, 3 Sep 2025 12:34:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1utmhN-0003p7-Lp; Wed, 03 Sep 2025 08:34:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utmhK-0003oi-TR for qemu-arm@nongnu.org; Wed, 03 Sep 2025 08:34:47 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1utmhI-0004O4-1r for qemu-arm@nongnu.org; Wed, 03 Sep 2025 08:34:46 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-b0472bd218bso45958966b.1 for ; Wed, 03 Sep 2025 05:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1756902882; x=1757507682; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vBaHsfDe8P7KwiBlbvzLrVAZAmqGGTji+Gl8IFTgJY8=; b=t+7nSwMte9Jpa7jWOVzdHH2xfH8YwnOBjIKS7ysfMumceMDYCKvxgig33O7FG6qicl b3oTlyUE2Tu9dcbbXTLd/1qn6HjAKKfXF5LQyjzjqPncpBJcQxa8vv7VT12cKc6pFJSO eO4QL2R3Y408AYn5rKs53xV9Sv+oUWA+DFJUhOIe9Z+P03bo/HX8NOjDnlGvjanv7O6P WGUiUtpcGog2Oc4MDy5b/hCoB17MxmLiX3qWAj7H74AYdXX5WXoiIwQCWptExbcRvW6D VwGvTgcqLjZI70+Qi0vwV7L5i7/P4oOyVZs9Xg6Yj7YkZjGleonTLpwMnXPo0WlcRfC+ t2ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756902882; x=1757507682; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vBaHsfDe8P7KwiBlbvzLrVAZAmqGGTji+Gl8IFTgJY8=; b=Oso+sB/E1UUsQllHUOASGTFlh00/sKHI6/A0RnyqipI/mfmCnnSdFCtjBiKMwtGbVZ 9dDbcwMgjkQAVG6gXMRAETF/BIH3r90AAIiauB0mdmUYlOg/a4KyRv/FNTYHh3iFqJJq jQU9lPy19Tp+wzp/AvW/NJkq8ptXtaThAhFe+rGieLF2lP3GeTp/3jE8l/mnLYiKDfSI 0ycDgSLUkttPSrsT7StCtdh6C1rZi4FtOnNOyY2oXQ3qJeMaz9k/fXdf8MEu7ucAG2sd PRb3h+o7msdMBbMY9m6wgVJCGS5agz2SGkTRAg0F16onw6RD7BFoB2Do4ydPv9hqnfKk W+bw== X-Forwarded-Encrypted: i=1; AJvYcCXgyXNOOvmGmf2+f4O2Y41UAqWG2Y3KgZn3iNXdIDR8fP+u3Fsj77togH+R6r9rnADVujX5wsZ90w==@nongnu.org X-Gm-Message-State: AOJu0Yxhn9PgUQD4bgaENsaHNl2tdg3Vw7vH7dHjEM3jBo8VLFKsdUDZ aKWIsn80L4RH9yaO1wEdpjl6qpS/z43zD22oIN8o0rL80utO27zjqmMnziaGYwFO3p4= X-Gm-Gg: ASbGncuBmQq1gnapsp2t9xB6pgycGMBxX+dYcC1dLEatJZ/16gAsC7Tuztngs/duMuU WgYO6n9NzGk1q0wWMPGF/OL+QogsnETLQA0Zs5DbCDt9qDavTdBqBzJRqq0fS3wFmrntvnXDx3H 0v2IVy0Xe4/hf6HcHPSsBc5LSToxFpu3QNZLWfsoabABQB5Fb47W43P1/3x5DrQZLl3XohheFUn jPeedW+ptI93Zp0iNccFKOqQ8mKqEErrG0iRLS8VQJiTyZEd8AbwtwNlDlydqS1iNEa07YKKQ3Y GHG0czUg2Ty5f9rWKqQ8/yS6UBkTJ8xDOWlaPGgYxsvPRuHQYqRzAd4iLMEh/3DbWWY5sBwZxWP HIcBeIbhYbBY9n3Fl8g6Fpmza1SRQtYNtrVAABz1ZiOGWOU9yWKwvrIS417dFwB5AwhjT6cES+X wsqxPYLCmGoH3McBJC X-Google-Smtp-Source: AGHT+IGs9tZWF0J9Kg15xbJA3ee6hYgAXRw1N9v+gE7WGTMpgiDsxrRV4wB2vuEKU/uX4FyRIv/ncA== X-Received: by 2002:a17:907:96ac:b0:af9:406d:f0a8 with SMTP id a640c23a62f3a-b01d8a7594amr1508198266b.23.1756902879369; Wed, 03 Sep 2025 05:34:39 -0700 (PDT) Received: from [10.40.6.207] (93-51-222-138.ip268.fastwebnet.it. [93.51.222.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b041770913fsm898957766b.107.2025.09.03.05.34.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Sep 2025 05:34:38 -0700 (PDT) Message-ID: Date: Wed, 3 Sep 2025 14:34:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/24] target/arm/hvf: Mention hvf_wfi() must run on vCPU thread To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Alexander Graf , qemu-arm@nongnu.org, Mohamed Mediouni , Peter Maydell , Mads Ynddal , Phil Dennis-Jordan , Stefan Hajnoczi , Cameron Esfahani , Roman Bolshakov , Paolo Bonzini References: <20250903100702.16726-1-philmd@linaro.org> <20250903100702.16726-9-philmd@linaro.org> From: Richard Henderson Content-Language: en-US In-Reply-To: <20250903100702.16726-9-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=richard.henderson@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 9/3/25 12:06, Philippe Mathieu-Daudé wrote: > Since hvf_wfi() calls hv_vcpu_get_sys_reg(), which > must run on a vCPU, it also must. Mention it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/hvf/hvf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c > index d87a41bcc53..05fc591b523 100644 > --- a/target/arm/hvf/hvf.c > +++ b/target/arm/hvf/hvf.c > @@ -1836,6 +1836,7 @@ static void hvf_wait_for_ipi(CPUState *cpu, struct timespec *ts) > bql_lock(); > } > > +/* Must be called by the owning thread */ > static void hvf_wfi(CPUState *cpu) > { > ARMCPU *arm_cpu = ARM_CPU(cpu); How can it not? Are all these separate patches and annotations helpful? r~