From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6B21C87FCC for ; Thu, 31 Jul 2025 08:30:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uhOgV-00041Y-F7; Thu, 31 Jul 2025 04:30:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uhOgJ-0003xi-Ic for qemu-arm@nongnu.org; Thu, 31 Jul 2025 04:30:34 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uhOgG-0008Gj-H3 for qemu-arm@nongnu.org; Thu, 31 Jul 2025 04:30:31 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4563a57f947so7001935e9.1 for ; Thu, 31 Jul 2025 01:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1753950624; x=1754555424; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Pd7UgNESfPtmW7raPCFpcrGuphL9U0VjTNjtnnNmoJE=; b=EaK54W9qgg0esVxyMaGAiVhC9X9W0d5RnkxvPuSRP2Xfh5RaPTg4ZSjhXbRk1Oisir bEKqWbNhaPnJP5E8K+AUK2DCGexfe9HcffK+Pmnq061Smkxnqic5wAUELUY2FgnueP4o 5RCWUb6r8/poklWfo/ptM2PMrH5Mr6IeJEUvu2flSUN01ehjEFqR4gWQq6hpxKt9xCrm lrzCOA9wnufrARfd5uvSJsp7JUi8ezR2SmA90cZQC7mNVwUzUda5z2v60i8yvs3phuoN kndpEdSPOauoNkVIOcqYQDzoEbKJnMLvC3fD3LrTdG/oQ75RmNITn1ROGxq92XhPXuoP 06Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753950624; x=1754555424; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Pd7UgNESfPtmW7raPCFpcrGuphL9U0VjTNjtnnNmoJE=; b=DCGor8P5X4gOilnc8hP756e56LyaNClqw9WPKJHKILmsPLVhJVd0rfjiV+hXXh/VwN xH1yLKWKm6nhZyYLZ0edZapMEi85sTUHHBpMVDARc7XoYRCEDQU9KyaAy2BhJ1vMUjS7 CeuusxMkQUscihV/nsj+qbCCQutdxpfIu/KWRZQ0tJdJVdpz4OHRoINjDrOKJGZ5WFVA 51o22BxOUHEouVpsbug6J6bOVf2x4W3A38GbtYhY6rAg1SSXqkNFehkN/4Dk1BMGLLWZ AaPxgEF4o11KhpvyrntSz2E1yqZU1Gf/uNBJSVEW3z74x9mqe8GgJFbKdRLg9e3DmE5y xr/A== X-Forwarded-Encrypted: i=1; AJvYcCXXRgrTzYEEvUq5BzmWbic9jiTHJTIhGGzc8j1+LvqTQYtOcKwz2BffWA/12ABfI1TmpUPL4SU0/g==@nongnu.org X-Gm-Message-State: AOJu0YzqLBNwYI3TQxilTXjipFmLRRzCkoeZ882OnCka4TyVsOy7dHD6 TE9xLcva1ib4pWqkfh5wBxEe4Mzs4NY6zVXVejeW/1KtTXOF2vtF+FigDFLCZjSV97c= X-Gm-Gg: ASbGncvmjf69qjSLVyx3BGoaRBE3OHAirYX5dDig30X7AmBbUVKIaomptf5R9b6Atp0 GEid6Qa7oRsXr6gcM5Fa9/Y4KvIg5f8xxe3G2XOJNHxxx6YVH+4U12cmHnO8yL2b0WNPXK17igL HUZM1tXW1+vyUjLdClnjt5o5LPfJAa1McDcfpXtJbNNCUrbTP2Jc4Wx+sH64fg+xcQRlPplWuV4 c42ObAKQlIXdTZKge7cxL+R4FvR+YxlYSIthDjUQNLuZSSfpOEC9Y4ocs6GkayBHulsC7Yfgtdw dEqhEJp2A9mO69nHhxO7qI1ZODAAs7e0bvGs4oPps+tvVQQZCTj+bixQNhGB/ShFixaVxjPTkrc i2cgCzRp6fg89wwD4pSKKAsK91azSYx+TZVcLrJr/N0WFoqHUgb53ugiT2P49loGmzCltFQNR9p j3 X-Google-Smtp-Source: AGHT+IHlM9yk90IuF5pxI3aaSJsksDr9W0Xpobn3XaVeFo4Z/0bWrAb6uuJPbzsl8MB6ZTHLWROdoQ== X-Received: by 2002:a05:600c:674a:b0:456:15a1:9ae0 with SMTP id 5b1f17b1804b1-458a223b223mr11642805e9.13.1753950624454; Thu, 31 Jul 2025 01:30:24 -0700 (PDT) Received: from [192.168.69.209] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b79c48105csm1574069f8f.64.2025.07.31.01.30.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 01:30:23 -0700 (PDT) Message-ID: Date: Thu, 31 Jul 2025 10:30:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 3/9] whpx: common: use whpx_cpu_instance_init on x86 only To: Mohamed Mediouni , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Paolo Bonzini , Sunil Muthuswamy , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Peter Maydell , qemu-arm@nongnu.org References: <20250731052753.93255-1-mohamed@unpredictable.fr> <20250731052753.93255-4-mohamed@unpredictable.fr> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250731052753.93255-4-mohamed@unpredictable.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Hi Mohamed, On 31/7/25 07:27, Mohamed Mediouni wrote: > We aren't using it on arm64. > > Signed-off-by: Mohamed Mediouni > --- > accel/whpx/whpx-common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c > index 0b23deb7c4..43d0200afd 100644 > --- a/accel/whpx/whpx-common.c > +++ b/accel/whpx/whpx-common.c > @@ -486,9 +486,10 @@ static void whpx_set_kernel_irqchip(Object *obj, Visitor *v, > > static void whpx_cpu_accel_class_init(ObjectClass *oc, const void *data) > { > +#ifdef __x86_64__ > AccelCPUClass *acc = ACCEL_CPU_CLASS(oc); > - > acc->cpu_instance_init = whpx_cpu_instance_init; > +#endif > } I'd rather keep whpx-*common* without any #ifdef'ry: add hooks when architecture-specific code need to be handled, and add empty arch stub when nothing to be done there (preferably with a comment in the stub).