[PATCH] tests/functional/aarch64: Skip some sbsaref_alpile tests by default

[PATCH] tests/functional/aarch64: Skip some sbsaref_alpile tests by default

[Thomas Huth]

From: Thomas Huth <thuth@redhat.com>

test_sbsaref_alpine is one of the longest running tests in our testsuite,
because it does a full Linux boot a couple of times, for various different
CPU configurations. That's quite a lot of testing each time, for a rather
small additional test coverage, so mark some of the tests with the
@skipSlowTest() decorator.

Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 See: https://lore.kernel.org/qemu-devel/87eczriaej.fsf@draig.linaro.org
 
 tests/functional/aarch64/test_sbsaref_alpine.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/functional/aarch64/test_sbsaref_alpine.py b/tests/functional/aarch64/test_sbsaref_alpine.py
index abb8f5114bd..33e77cc7049 100755
--- a/tests/functional/aarch64/test_sbsaref_alpine.py
+++ b/tests/functional/aarch64/test_sbsaref_alpine.py
@@ -41,12 +41,14 @@ def boot_alpine_linux(self, cpu=None):
         self.vm.launch()
         wait_for_console_pattern(self, "Welcome to Alpine Linux 3.17")
 
+    @skipSlowTest()
     def test_sbsaref_alpine_linux_cortex_a57(self):
         self.boot_alpine_linux("cortex-a57")
 
     def test_sbsaref_alpine_linux_default_cpu(self):
         self.boot_alpine_linux()
 
+    @skipSlowTest()
     def test_sbsaref_alpine_linux_max_pauth_off(self):
         self.boot_alpine_linux("max,pauth=off")
 
-- 
2.51.0

Re: [PATCH] tests/functional/aarch64: Skip some sbsaref_alpile tests by default

[Peter Maydell]

On Mon, 6 Oct 2025 at 12:50, Thomas Huth <thuth@redhat.com> wrote:
>
> From: Thomas Huth <thuth@redhat.com>
>
> test_sbsaref_alpine is one of the longest running tests in our testsuite,
> because it does a full Linux boot a couple of times, for various different
> CPU configurations. That's quite a lot of testing each time, for a rather
> small additional test coverage, so mark some of the tests with the
> @skipSlowTest() decorator.
>
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  See: https://lore.kernel.org/qemu-devel/87eczriaej.fsf@draig.linaro.org

That suggests dropping the subtests entirely, not merely
marking them as "slow". I think I agree with that.

>  tests/functional/aarch64/test_sbsaref_alpine.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/functional/aarch64/test_sbsaref_alpine.py b/tests/functional/aarch64/test_sbsaref_alpine.py
> index abb8f5114bd..33e77cc7049 100755
> --- a/tests/functional/aarch64/test_sbsaref_alpine.py
> +++ b/tests/functional/aarch64/test_sbsaref_alpine.py
> @@ -41,12 +41,14 @@ def boot_alpine_linux(self, cpu=None):
>          self.vm.launch()
>          wait_for_console_pattern(self, "Welcome to Alpine Linux 3.17")
>
> +    @skipSlowTest()
>      def test_sbsaref_alpine_linux_cortex_a57(self):
>          self.boot_alpine_linux("cortex-a57")
>
>      def test_sbsaref_alpine_linux_default_cpu(self):
>          self.boot_alpine_linux()
>
> +    @skipSlowTest()
>      def test_sbsaref_alpine_linux_max_pauth_off(self):
>          self.boot_alpine_linux("max,pauth=off")

This is odd, because the slow case is the default CPU
one, not the pauth=off one (which is faster because we
are disabling the slow pauth checks).

thanks
-- PMM

Re: [PATCH] tests/functional/aarch64: Skip some sbsaref_alpile tests by default

[Philippe Mathieu-Daudé]

On 6/10/25 13:50, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> test_sbsaref_alpine is one of the longest running tests in our testsuite,
> because it does a full Linux boot a couple of times, for various different
> CPU configurations. That's quite a lot of testing each time, for a rather
> small additional test coverage, so mark some of the tests with the
> @skipSlowTest() decorator.
> 
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   See: https://lore.kernel.org/qemu-devel/87eczriaej.fsf@draig.linaro.org
>   
>   tests/functional/aarch64/test_sbsaref_alpine.py | 2 ++
>   1 file changed, 2 insertions(+)

'alpile' typo in subject.