From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ad09:0:0:0:0:0 with SMTP id t9csp1122814lfc; Thu, 3 Sep 2020 21:35:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyw5LqbzLRZ4no/JrcVON06QLiHPorwq9d15NdIHmNKc+ZVwnaZveLAbJsyj15bD62QZl9t X-Received: by 2002:a25:6e54:: with SMTP id j81mr7364566ybc.194.1599194111284; Thu, 03 Sep 2020 21:35:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599194111; cv=none; d=google.com; s=arc-20160816; b=nOsl98IaJi8wPttpYVnZm7q2/GZ+PortDLmbr7bM6+YtzskuT510J39dl46CArjZkM m58pxtBL316q5Dkoy7AXqh/bLinUsJ47mAxGkybbuZ35qp9hsxKHqr8C57ll4ZteKzg/ I0r/IcOrSKvYf33czPBNz4Uv/JnQTT0OnBvYJNHEsHKXd64Vb89SGRg3VdexVPQM9W4i 4pBK/Lmt8ml0nFszO0mMpSIGrb89MY+5cU6lqFV673nKatAWgs+2KaNYW7N0HNJ4yCcc GCMILGRxMz5rkBRqQLSc7J4AM7DXS5m7N6ZJ2rWxqK2iutLCbsjHreSJbx/+/z4OKe68 A90A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=4tX42JeuT11tVwYg7ef2XUqO8sjNN+gdBUPZysbX08E=; b=MietWXdwpbsuUoasNrBokYzl/cqd3Rxtbe9DdA3ssOo1fs5eVOEo5WoHg9wBwUuzat 43a/wfp/m79Sw0Pi4OIjAMxrYGHFBT82loUKX5wMujjroRCSCmUJ24wAFRH3AQkF3pE8 Bwfh84oAfKIUqopSW3U9gt4j7mtv429/jrFtjuHZe4aSeiwH984+0MFgPrFMcKq4G1gE JhB32Ophs00iGQBvOjHUvxWFz0j2NndzhVSvugnUEGfZBDWrXouvVCsknpTiaazAfw+i W81FbQPNwWbgmlfLQGkCoDIcsjb3JlF8uqx5MhpWyeXRF0X+jF8CaoTVSdOnNNbRrwhZ vIAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=EluCZBcy; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id u6si193414ybd.18.2020.09.03.21.35.11 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Sep 2020 21:35:11 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=EluCZBcy; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:55952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE3RO-0006Ac-MM for alex.bennee@linaro.org; Fri, 04 Sep 2020 00:35:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE3RG-00068L-NO for qemu-arm@nongnu.org; Fri, 04 Sep 2020 00:35:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:26967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kE3RC-00021f-D0 for qemu-arm@nongnu.org; Fri, 04 Sep 2020 00:35:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599194097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4tX42JeuT11tVwYg7ef2XUqO8sjNN+gdBUPZysbX08E=; b=EluCZBcyCpq81RrBHJ0esz6MM1VjAUwFOYBDfKuyigVdvNeGaoGfib+o3Q6SO07Nmss242 siW7WEn+t/4aizYbndOvvQIeI6qAIOZVhceI+ndC4o669a/wdbPPHu1nb3V2Vvd4tCHEpD p5sv+IqpveR8JXQwoNkZZ8/Atjp1ahk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-E-lusR5jPTSbN6k5sU1Lgg-1; Fri, 04 Sep 2020 00:34:55 -0400 X-MC-Unique: E-lusR5jPTSbN6k5sU1Lgg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 31A5818B9F84; Fri, 4 Sep 2020 04:34:53 +0000 (UTC) Received: from [10.72.13.157] (ovpn-13-157.pek2.redhat.com [10.72.13.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8F6B1002D57; Fri, 4 Sep 2020 04:34:34 +0000 (UTC) Subject: Re: [PATCH 5/5] memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , Peter Xu , qemu-devel@nongnu.org References: <20200625191651.5817-1-eperezma@redhat.com> <20200903161446.29615-1-eperezma@redhat.com> <20200903161446.29615-6-eperezma@redhat.com> From: Jason Wang Message-ID: Date: Fri, 4 Sep 2020 12:34:33 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200903161446.29615-6-eperezma@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/03 22:51:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.403, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Aleksandar Rikalo , Yan Zhao , Eduardo Habkost , "Michael S. Tsirkin" , Juan Quintela , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Eric Auger , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Avi Kivity , Marcel Apfelbaum , Paolo Bonzini , David Gibson , Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: qCBefJ9dUc6W On 2020/9/4 上午12:14, Eugenio Pérez wrote: > Device IOTLB invalidations can unmap arbitrary ranges, eiter outside of > the memory region or even [0, ~0ULL] for all the space. The assertion > could be hit by a guest, and rhel7 guest effectively hit it. > > Signed-off-by: Eugenio Pérez > Reviewed-by: Peter Xu > Reviewed-by: Juan Quintela > --- > softmmu/memory.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/softmmu/memory.c b/softmmu/memory.c > index 8694fc7cf7..e723fcbaa1 100644 > --- a/softmmu/memory.c > +++ b/softmmu/memory.c > @@ -1895,6 +1895,7 @@ void memory_region_notify_iommu_one(IOMMUNotifier *notifier, > { > IOMMUTLBEntry *entry = &event->entry; > hwaddr entry_end = entry->iova + entry->addr_mask; > + IOMMUTLBEntry tmp = *entry; > > if (event->type == IOMMU_NOTIFIER_UNMAP) { > assert(entry->perm == IOMMU_NONE); > @@ -1908,10 +1909,18 @@ void memory_region_notify_iommu_one(IOMMUNotifier *notifier, > return; > } > > - assert(entry->iova >= notifier->start && entry_end <= notifier->end); > + if (notifier->notifier_flags & IOMMU_NOTIFIER_DEVIOTLB_UNMAP) { > + /* Crop (iova, addr_mask) to range */ > + tmp.iova = MAX(tmp.iova, notifier->start); > + tmp.addr_mask = MIN(entry_end, notifier->end) - tmp.iova; > + /* Confirm no underflow */ > + assert(MIN(entry_end, notifier->end) >= tmp.iova); It's still not clear to me why we need such assert. Consider notifier->end is the possible IOVA range but not possible device IOTLB invalidation range (e.g it allows [0, ULLONG_MAX]). Thanks > + } else { > + assert(entry->iova >= notifier->start && entry_end <= notifier->end); > + } > > if (event->type & notifier->notifier_flags) { > - notifier->notify(notifier, entry); > + notifier->notify(notifier, &tmp); > } > } >