qemu-arm.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: cota@braap.org, famz@redhat.com, berrange@redhat.com,
	f4bug@amsat.org, balrogg@gmail.com, aurelien@aurel32.net,
	agraf@suse.de, qemu-devel@nongnu.org,
	Peter Maydell <peter.maydell@linaro.org>,
	"open list:ARM" <qemu-arm@nongnu.org>
Subject: Re: [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test
Date: Thu, 17 May 2018 14:34:05 -0700	[thread overview]
Message-ID: <dd18fb0e-437e-d551-171e-a748ff3ede22@linaro.org> (raw)
In-Reply-To: <87muwydlgc.fsf@linaro.org>

On 05/17/2018 02:24 PM, Alex Bennée wrote:
> 
> Richard Henderson <richard.henderson@linaro.org> writes:
> 
>> On 05/17/2018 10:46 AM, Alex Bennée wrote:
>>> Broken since I updated to 18.04
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>>  tests/tcg/arm/Makefile.target | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>
>> Meh.  Most of these fail for hosts with 64k pages.
>> So, sure, disable this one, but I don't think that
>> the others are useful either.
> 
> I'm not entirely sure what the point of -p is meant to be. Is it just a
> performance hack for linux-user to have bigger pages? We are not using
> softmmu but I guess it affects the PageDesc structures?

I think it was just meant for testing, but I really have no idea.

If we actually had better support for mismatched host/guest page sizes, then
one could view -p as a way to choose between legitimate guest page sizes.  E.g.
8k, 16k, 64k are all legitimate for aarch64.


r~

  reply	other threads:[~2018-05-17 21:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180517174718.10107-1-alex.bennee@linaro.org>
2018-05-17 17:46 ` [PATCH v4 26/49] tests/tcg: move ARM specific tests into subdir Alex Bennée
2018-05-18 15:26   ` Philippe Mathieu-Daudé
2018-05-18 15:58     ` Alex Bennée
2018-05-17 17:46 ` [PATCH v4 27/49] tests/tcg: enable building for ARM Alex Bennée
2018-05-18 15:28   ` Philippe Mathieu-Daudé
2018-05-18 15:48     ` Alex Bennée
2018-05-17 17:46 ` [PATCH v4 28/49] tests/tcg/arm: fix up test-arm-iwmmxt test Alex Bennée
2018-05-17 20:15   ` Richard Henderson
2018-05-17 17:46 ` [PATCH v4 29/49] tests/tcg/arm: disable -p 32768 mmap test Alex Bennée
2018-05-17 20:20   ` Richard Henderson
2018-05-17 21:24     ` Alex Bennée
2018-05-17 21:34       ` Richard Henderson [this message]
2018-05-18  3:47         ` Philippe Mathieu-Daudé
2018-05-17 17:46 ` [PATCH v4 30/49] tests/tcg: enable building for AArch64 Alex Bennée
2018-05-17 20:26   ` Richard Henderson
2018-05-18 14:57   ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [PATCH v4 31/49] tests/tcg/aarch64: add Makefile.target Alex Bennée
2018-05-17 20:28   ` Richard Henderson
2018-05-17 21:25     ` Alex Bennée
2018-05-17 17:47 ` [PATCH v4 32/49] tests/tcg/arm: add fcvt test cases for AArch32/64 Alex Bennée
2018-05-17 20:30   ` Richard Henderson
2018-05-18  3:45     ` Philippe Mathieu-Daudé
2018-05-18  8:16       ` Alex Bennée
2018-05-18 14:53         ` Philippe Mathieu-Daudé
2018-05-17 17:47 ` [PATCH v4 49/49] tests/tcg: override runners for broken tests (!UPSTREAM) Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd18fb0e-437e-d551-171e-a748ff3ede22@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=agraf@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=balrogg@gmail.com \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).