From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:6d5:0:0:0:0:0 with SMTP id 204csp6413064lfg; Thu, 4 Mar 2021 09:13:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0bvl40T40iS0bK4x/hAWIrrdbWLr0iujBZ2S2PpSMODKe/896j7JQSlSu/yJJTvaapaca X-Received: by 2002:a92:6b0f:: with SMTP id g15mr5038113ilc.144.1614878010262; Thu, 04 Mar 2021 09:13:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614878010; cv=none; d=google.com; s=arc-20160816; b=MLA+FKxHa9qbqdbp1VubEV0JFF/9IE2k3+rTE1bih513UueqkLubHtUcATC0AObSj+ zFmnFgtnIOnRW5DyWovsegUGjJmGtzzUflg7QASiOBpCKGyzlGYTMxstdwx5JnQbhHFU XRkilbAU9ksmavwG12p9k+FCQ1O9TgW/CJ1Ud+jo3FjYYUEdRLyTh3zaH4Y/DFdgitJA xiTDuRwZe4cF63QxY0qRGqg8ZOjILt2A9+1TmIggKI8617dzKiwTamjRChL1L9FCPPvm jG3gW80Ynu6mKeyshhzP8Wn0198U8bsQbEUOyAuVgVdFjOQaQZzZ1w2nW7Fg7ZcHlaVH /CPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=UTM8r/yF+JYECnPc5aEAPc157zPtTHvqVNPDoOG9R44=; b=Yi1V0NMf9VZDNXIPe7G50neBR+t7azbcvPI6yMcUr/4og8dMSpAUclo3I2ZIGFpt3J LtVTuMMSzpDcsdEVioMSGtbaWg7Z2Fa9VZhmPIyE5e6aEd69CzqE+0sfYUyLeUY4dahh bd9W18eja0kv7V0ar9mystvN1oXnmgFFDszlN1WhPVc2z0isZfSlOj+hBbUqLKRipB+0 C4tDmah/P63rzTX8Vb/FvFL/nnccPdV11uNLpLlPHcs/hSHBNUakDnOBCFfIgfUofipV ypYy7a9tsCUkqp5PVVMkDttdKUVEUqTTSrMOI+Ngok7yitGTYviqNizHFxjUOvsXaWpc 0iSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rqMfY6uz; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c17si12374206jap.11.2021.03.04.09.13.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Mar 2021 09:13:30 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rqMfY6uz; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:59846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHrXV-0004pJ-Hz for alex.bennee@linaro.org; Thu, 04 Mar 2021 12:13:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHrXE-0004no-GM for qemu-arm@nongnu.org; Thu, 04 Mar 2021 12:13:12 -0500 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:46392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHrXA-0007yq-AD for qemu-arm@nongnu.org; Thu, 04 Mar 2021 12:13:12 -0500 Received: by mail-pf1-x42c.google.com with SMTP id r5so19379918pfh.13 for ; Thu, 04 Mar 2021 09:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=UTM8r/yF+JYECnPc5aEAPc157zPtTHvqVNPDoOG9R44=; b=rqMfY6uzO03mEhIzNa0HxmSxtb3i9ST/4bYp2kRbjqpFA9m9+YtntROB0cAVZSP49S aI3bQoNKmJfZMP5Geo+lVb2yl9Sn9XMErSGlcl99vuq7/7ZZV6Ff+OK6I5tnhBoijN10 EcPtWm4x+TyyIGnqEzIVfSUwz2hEx0oSjfZ5B3hXStXfx9qF/WE0T90efdh6nHtVzf60 8PJgip64vX//YyvlLVBsKnl8Sg9l8ysT2zAP4jLbNfy+XSn4gdM24UHT4tqv8qjkW0ju hf3mh5ZLRdEAugZkHbkO+eerlLG70A3+yjG8o7DVt9fRNqTBhY3kLuJBGZfS8HFg53+v kijw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UTM8r/yF+JYECnPc5aEAPc157zPtTHvqVNPDoOG9R44=; b=Ze6UtDNdqwxTHNAdG8aKh+u1MOfxCeXsWv8UdrlHbTzebLAhlfTUHivF1lVBa8ABWv XWmGIH5szORti3N2p/SmsJCy2gEpcJVxMFqI845toHWWTzXuLJ7M59woBfppu9tdaeAT Ijdvbj5kfXqVctlI0iC8xIw9aPtp6JLsJUHopm6lKnJN+4ZIup9IyV2Sqp44Yh0DH+VL QUB01VtZ3x5z/U9LCs6Wa0hk53WhYnCbYYQM9dCwnnuNSBkicT04aLtgZWawNZ68Yaoo fjCdJSqY1sG39BXhViCvZq5Kizw4t08E6MBlaLNcB2k6ZiwXNzwlBINvpHPWo5ouBQK8 MBUA== X-Gm-Message-State: AOAM5316dSJJX65aAYlr6/5292vHc336sOhtjFe4FQxHchqEvVWLQ9V7 RiGjqRltWWLljA0Zhuiny2Uknw== X-Received: by 2002:a63:4513:: with SMTP id s19mr4339816pga.229.1614877986778; Thu, 04 Mar 2021 09:13:06 -0800 (PST) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id t22sm5632100pjw.54.2021.03.04.09.13.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 09:13:06 -0800 (PST) Subject: Re: [PATCH 06/44] hw/misc/iotkit-sysctl: Remove is_sse200 flag To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210219144617.4782-1-peter.maydell@linaro.org> <20210219144617.4782-7-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Thu, 4 Mar 2021 09:13:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210219144617.4782-7-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: VMAPIZpDOfbE On 2/19/21 6:45 AM, Peter Maydell wrote: > Remove the is_sse200 flag in favour of just directly testing the new > sse_version field. > > Since some of these registers exist in the SSE-300 but some do not or > have different behaviour, we expand out the if() statements in the > read and write functions into switch()es, so we have an easy place to > put SSE-300 specific behaviour. > > (Until we do add the SSE-300 behaviour, the thing preventing us > reaching the "unreachable" default cases is that armsse.c doesn't > yet pass us an ARMSSE_SSE300 version.) > > Signed-off-by: Peter Maydell > --- > include/hw/misc/iotkit-sysctl.h | 2 - > hw/misc/iotkit-sysctl.c | 256 +++++++++++++++++++++++--------- > 2 files changed, 187 insertions(+), 71 deletions(-) Reviewed-by: Richard Henderson r~