From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:b64b:0:0:0:0:0 with SMTP id i11-v6csp4528813wre; Wed, 30 May 2018 02:33:06 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK9+xYW5sKqzxwTxIt8TW8Txxq0pj925izXu18fLTnc1Ue9YFUEU3lKBEYDXBSwqiiv9Y0v X-Received: by 2002:a0c:8906:: with SMTP id 6-v6mr1662884qvp.249.1527672786585; Wed, 30 May 2018 02:33:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527672786; cv=none; d=google.com; s=arc-20160816; b=Vdl+UEbmogvlCu7gKktzx603A+f63h1fvwQY+ryqxoXMw24OhHQvOhYUCz15jbRu7w cFgsyq9ukAKYJ27x62ivIhCjbVCr+dLv8Qj2pSxUdorLil9EoMGqn03OtDOQdqVrPJQR LZ++crwg2GLfhQkk/e/BYXnVpc0AcdDvPkRNKeBC8uD97Z4DwMVDKZpdtGyC7ZBzfIsp o6zme0EuyMIjfkz2ydBxUPPSZgdcLDJfTGxEsCWbRCzJ3O6P+s9m5su1THtvkw2d2Wt6 x2Zgn3ZCuVOh9/+HYA7dtZRwjZeYhPm09HRomcvFuf0JqyNDp4vi9fe39ryL1R+6FVcy GVdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:autocrypt:openpgp:from:references:to :arc-authentication-results; bh=DJU5FAhWi64Btwv8Vr1Nb4+u48zJ10JqoOysvOZunR8=; b=ajhxIQKl+v8YI++V0VMn0x2WaLKHQI5fijGp5gdiKLp+sCtUxVFNCF3YMCqOAR4KVe TT1Kz2RkpEBeoxpUvS2eyjuURhH0PSMsaRxHppPv2k/Tv0QBl0dXQ8l6YpnIn8FT3k5r yYkSzHNobBu7INGKDfft06YYCzEiWSn9+uPg3XE5TA1cAbG9onV9utNAQ1tGh0YdzA+c 83Gkia/vVYWIc7xEEj1ZEBLxBqr4bgT8e06rLgqE1HUeeLIvseaYeX1cis2km69pH3kL Tg+/ZhQVABJBmRKP+UCQH2BxXS1+0ziO5lBknt7tIWaq97w84fwS8GL4W/NeFICZQYVH AYzw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y12-v6si626003qvn.85.2018.05.30.02.33.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 30 May 2018 02:33:06 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:37196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNxTe-0006YG-1g for alex.bennee@linaro.org; Wed, 30 May 2018 05:33:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNxTQ-0006Y3-JH for qemu-arm@nongnu.org; Wed, 30 May 2018 05:32:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNxTN-0003iF-Eo for qemu-arm@nongnu.org; Wed, 30 May 2018 05:32:52 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44572 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fNxTN-0003i5-9g; Wed, 30 May 2018 05:32:49 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BBAD2401EF0E; Wed, 30 May 2018 09:32:47 +0000 (UTC) Received: from [10.36.118.56] (unknown [10.36.118.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8246B10F1C13; Wed, 30 May 2018 09:32:39 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , "Michael S. Tsirkin" References: <20180528232719.4721-1-f4bug@amsat.org> <20180528232719.4721-10-f4bug@amsat.org> <20180529134053.1ea9f46d.cohuck@redhat.com> <11289f38-6d0f-74c9-1719-83b2a3ed2d97@amsat.org> <20180530074026-mutt-send-email-mst@kernel.org> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; prefer-encrypt=mutual; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0f UGFvbG8gQm9uemluaSA8Ym9uemluaUBnbnUub3JnPsLBTQQTAQIAIwUCVEJ7AwIbAwcLCQgH AwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEH4VEAzNNmmxNcwOniaZVLsuy1lW/ntYCA0Caz0i sHpmecK8aWlvL9wpQCk4GlOX9L1emyYXZPmzIYB0IRqmSzAlZxi+A2qm9XOxs5gJ2xqMEXX5 FMtUH3kpkWWJeLqe7z0EoQdUI4EG988uv/tdZyqjUn2XJE+K01x7r3MkUSFz/HZKZiCvYuze VlS0NTYdUt5jBXualvAwNKfxEkrxeHjxgdFHjYWhjflahY7TNRmuqPM/Lx7wAuyoDjlYNE40 Z+Kun4/KjMbjgpcF4Nf3PJQR8qXI6p3so2qsSn91tY7DFSJO6v2HwFJkC2jU95wxfNmTEUZc znXahYbVOwCDJRuPrE5GKFd/XJU9u5hNtr/uYipHij01WXal2cce1S5mn1/HuM1yo1u8xdHy IupCd57EWI948e8BlhpujUCU2tzOb2iYS0kpmJ9/oLVZrOcSZCcCl2P0AaCAsj59z2kwQS9D du0WxUs8waso0Qq6tDEHo8yLCOJDzSz4oojTtWe4zsulVnWV+wu70AioemAT8S6JOtlu60C5 dHgQUD1Tp+ReXpDKXmjbASJx4otvW0qah3o6JaqO79tbDqIvncu3tewwp6c85uZd48JnIOh3 utBAu684nJakbbvZUGikJfxd887ATQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAem Vv9Yfn2PbDIbxXqLff7oyVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CR wkMHtOmzQiQ2tSLjKh/cHeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuf fAb589AJW50kkQK9VD/9QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v02 8TVAaYbIhxvDY0hUQE4r8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQ zCYHXAzwnGi8WU9iuE1P0wARAQABwsEzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EO oJy0uZggJm7gZKeJ7iUpeX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBT uiJ0bfo55SWsUNN+c9hhIX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHn plOzCXHvmdlW0i6SrMsBDl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4 HYv/7ZnASVkR5EERFF3+6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz 876SvcOb5SL5SKg9/rCBufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvr iy9enJ8kxJwhC0ECbSKFY+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y 1lJAPPSIqZKvHzGShdh8DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT /ujKaGd4vxG2Ei+MMNDmS1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO 53DliFMkVTecLptsXaesuUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: Date: Wed, 30 May 2018 11:32:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 30 May 2018 09:32:47 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 30 May 2018 09:32:47 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'pbonzini@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-arm] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , Eduardo Habkost , David Hildenbrand , QEMU Trivial , Anthony Green , Cornelia Huck , "qemu-devel@nongnu.org Developers" , Alexander Graf , Laurent Vivier , Max Filippov , Michael Walle , "open list:ARM" , "open list:PowerPC" , Marcel Apfelbaum , "open list:S390" , Stafford Horne , David Gibson , Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: Gluk0a5IWoXZ On 30/05/2018 07:50, Philippe Mathieu-Daud=C3=A9 wrote: >>> No, not all :/ >>> I started with "(cpu_loop_|tlb_|tb_)" then kept brutebuilding until n= o >>> more errors appear. In 2 more steps I added "cpu_address_space_init|" >>> then "|GETPC|singlestep|TranslationBlock". Quick and dirty enough for= my >>> goal than trying to build a regex to explode function/struct names fr= om >>> headers. This is a clever way to do it for long term command reuse ta= ken >>> from commit messages... >> Brutebuilding isn't a good way to find unused includes, some other hea= der >> might pull in an include you are trying to remove for its own purposes= . >> If you want to try brutebuilding you must also verify that's >> not the case - e.g. look at the dependency file generated. > Hmm you mean the .d files in the build dir? You can also check which include files include this one. In this case you can see that brute-building was more or less enough: $ git grep -l exec-all -- '*.h' accel/tcg/translate-all.h include/exec/tb-lookup.h include/exec/translator.h linux-user/qemu.h target/ppc/helper_regs.h Leaving aside linux-user/qemu.h, let's check which files include one of those headers, but they do not include exec/exec-all.h: $ git grep -L exec-all \ $(git grep -lFf <(git grep -l exec-all -- '*.h' | \ grep -v qemu.h | sed 's,.*/,,')) linux-user/mmap.c target/arm/translate.h target/ppc/int_helper.c trace/control-target.c I'll send some patches shortly to fix up what's left. Paolo