From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:4310:0:0:0:0:0 with SMTP id q16csp2297727lfa; Sat, 5 Jun 2021 15:20:02 -0700 (PDT) X-Received: by 2002:a17:902:7e4e:b029:f0:d949:8ab3 with SMTP id a14-20020a1709027e4eb02900f0d9498ab3mr10763794pln.40.1622931602425; Sat, 05 Jun 2021 15:20:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622931602; cv=none; d=google.com; s=arc-20160816; b=GHNUey34Ir+N14pBH3tahMmxj8kl7kSbul5Gfxlba989bkvuUSgVlYelZ+uI77Lz+F MDqV0jmvMnxXI+vejj98/Qtv5SrcZF+Y3GccSq/BwKQQZYqOHAWIE+OOC0FyEhjLmsm8 x6dzo2Bv1Ze9gnT5SxlNp1h/5a7DxlrV9ThP3cF3ju+3QRoaYeLgSon8R++AIPx8q9dX CQT78ukCI3NpzpFLNC63LYY/mP9zZd7jsPgw2pPKvuxsEm8jDfwnZDc5/pwt7B9iI1qa uRrQHi3iZvqKoFJV43mqgmYp5iVuzGlFl/8AeJ31EHRp07laAHXnJm3mxlMdJnftUTwY 4Vyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=pdXjljtdkByoyL+Llw8CXo3LgFSrDw9P4B0jFH0zp8s=; b=UfMJ/MnWAHZth2mqXPQwVqyFaEaUDaqx89gctuvnpRATZvUsGj9h/VmQ0Nkqybw5FU RzkkuFC0hr4LPgA1bSAvTxZp46i5NQqchmF9xjBp3dtDGHb1eMiQV5RqHIBg2Al56QAI P1DigIuXMMflaphtiu+XG/LbVnxRQV2/U6n8K9oB7Hnh4sNQ0PUa49K2OZ05E/PlAGbi 5SVT4JmOKjq/TLsjuTYLNy8cOcUkVOsU9F6KVogNIiKJiPtyIHdDiqX3Po1mk/ymQtvg 55EOTmuQGl8E+1jskwhjB3ESnkgH77v0TzeunWd1iau5lhlXaQnwyzYspPxRDuYObCGc gceA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Sf2qI/C+"; spf=pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id d14sor5755090pjm.15.2021.06.05.15.20.02 for (Google Transport Security); Sat, 05 Jun 2021 15:20:02 -0700 (PDT) Received-SPF: pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.41 as permitted sender) client-ip=209.85.220.41; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Sf2qI/C+"; spf=pass (google.com: domain of richard.henderson@linaro.org designates 209.85.220.41 as permitted sender) smtp.mailfrom=richard.henderson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pdXjljtdkByoyL+Llw8CXo3LgFSrDw9P4B0jFH0zp8s=; b=Sf2qI/C+z1qrrcIFb7yO5N5TtWGCCzGAz0qZWjzVxDNCW3j/qZekaLhmowMrTVgQnA hO/Kgj3Zb9LYNSWUMDq5aMfpf/dZgrAlKal3H4j46WttUdh8yIZ0sIy7/u4kz7hQ1J1p 54B0HS17ZetxqArq3YOkeDpZue+KP7WSOvwxGOnrcuFglMudpFCpmZyUiOg/5F+aT8Kx qeVT/jrGRDmAB3RDlxBq84mpVlYS46qIN3prgsPQHrchRb7Dz1o+x2ClPX+S4ImhqnSB YlZiwpzLzUGHDWvDp5TqLeUsye8hgugk2mUcR0i5r9osseIPeNtQSHJSnFiTLBhfb6JK npAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pdXjljtdkByoyL+Llw8CXo3LgFSrDw9P4B0jFH0zp8s=; b=jmpFkfEeqby5wOaaBRCr0JalypJDnKedxvHFWDdn5mXOy73xNrx9SuPFXi5z4hF7I8 15XFu1oTi/aO14oHWyr5E82Du00f0+Clch19ijKRCkpJVr0UNYInJWdGPQfOJIh3ln7u vdtwY/9s28Yc5wlHab8Sj2K8tjvYD5hM47UXmHjKJ+lym6XPoN+0CbcAddNphMBEQEAs CQv0WwfbTX202sstbBuo/U+bBxYMpF0WpW+cmWBBAfS9z6wPGU6S3QeWflHmZb9ayhMc KgF9ga2G3gUIcGhX0mODSKLr7whkODKeXPEr0g3bVZAT3RRbV7itP8U3wXsJfb9yz9O7 DqHA== X-Gm-Message-State: AOAM531nur792/kpKzxKrE+MAmocuzErqb1jB1Rk5MvxxYM4ZSyhBiBI 4Y7vj4uj2giEByuhd5Ti0awT8j6y X-Google-Smtp-Source: ABdhPJwtTg6+lMWYOK+lwK0BLWdu1W8cyi2DFrsNMMiJjCCWSyw6lb/v8DAUrlwPtASn8Ec8tcjMWg== X-Received: by 2002:a17:90a:1b64:: with SMTP id q91mr11951058pjq.184.1622931601967; Sat, 05 Jun 2021 15:20:01 -0700 (PDT) Return-Path: Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id fu21sm7832703pjb.38.2021.06.05.15.20.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Jun 2021 15:20:01 -0700 (PDT) Subject: Re: [PATCH v16 89/99] target/arm: cpu64: some final cleanup on aarch64_cpu_finalize_features To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Claudio Fontana References: <20210604155312.15902-1-alex.bennee@linaro.org> <20210604155312.15902-90-alex.bennee@linaro.org> From: Richard Henderson Message-ID: Date: Sat, 5 Jun 2021 15:20:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210604155312.15902-90-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: YNmQ7RFX9n5A On 6/4/21 8:53 AM, Alex Bennée wrote: > From: Claudio Fontana > > bail out immediately if ARM_FEATURE_AARCH64 is not set, > and add an else statement when checking for accelerators. > > Signed-off-by: Claudio Fontana > Signed-off-by: Alex Bennée > --- > target/arm/cpu64.c | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) > > diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c > index 3058e2c273..ecce8c4308 100644 > --- a/target/arm/cpu64.c > +++ b/target/arm/cpu64.c > @@ -473,26 +473,25 @@ void aarch64_cpu_finalize_features(ARMCPU *cpu, Error **errp) > { > Error *local_err = NULL; > > - if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) { > - if (!cpu_sve_finalize_features(cpu, &local_err)) { > + if (!arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) { > + return; > + } I'm not sure this is correct, either before or after. What about nonsensical combinations such as -cpu max,aarch64=off,sve-vq-max=4 Don't we want cpu_sve_finalize_features and friends to produce an error about enabling sve without aarch64. r~