From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:e8d:0:0:0:0:0 with SMTP id 135csp634657lfo; Tue, 2 Feb 2021 18:43:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnzVMJBOjmQk08nILVoH9LpV6HsLC1V3eu3BnYkCxDQGW/FB9FbefKdBtB9QCOEVrblpPp X-Received: by 2002:a25:e055:: with SMTP id x82mr1290777ybg.59.1612320227272; Tue, 02 Feb 2021 18:43:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612320227; cv=none; d=google.com; s=arc-20160816; b=gQkDtEQYyTV94ow+SKt5xIs9OMROhfj1gLksvZzfC8dk7DzqCjzsJo0sMQ4xD1ALxQ UwjkvdwfVCovZHG7BdQ0lQEWXo4/SZEx4MXFt82E4oHGe1fT2/51IXjbA8NRjE/6IhKO 4a9UG3aykjcGkzadD4c82YlYqY4kDV/QQWYn9500h/Ehyur72f+rfXqSUuSNjpj6b1pO ZQ/hmms6P4Acvqs9fcIi5zPJC3mDQ7JDBjLpM4B/MeD2u6z20+I04BCSNnTBS7EleLDO LbjdGkS7meIGBmrST9nnjJVBebPtcYQ/famphUvAcUMCbgtBZBrEfkEkkYFboHleL5o5 GPkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=OQUXtjjBRqzQtTa2aivLBliJb+EH57HgyvLFb4ZVM0I=; b=VmDGveZ7PBoLSaaCK8dbDJTMnOzWvIrJYZO92iuYycenuh6u/RnPrwDElHpAd68Ab0 yN5bCjRFaSyOF3uZgCLVHJV2rKBe9zLzlgxNeUv16tNCg9Lv4gMTPLOBVOgXjMCwDf7+ IFuYUldhchAkAQtmGufWel8VqWIGwlaIxjyBvj3p9w6oC867Fl/Yb/MmUJrquBwrnbPt 23AEZA32/132Ep5lMoVWZ/o0y0J8IAM1P/cZ2ADRYtRfcN+uCi6T9SL0ipb6YRXFFeog PAyFmOX5W6Xg82BAlqA6JnjYdVOOi5PkTC6ZzZPsL2iqZ7xZOdWGT19e/gC6Hc8x9ZtM CDpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xYUd0fT7; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id j13si873974ybp.459.2021.02.02.18.43.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Feb 2021 18:43:47 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=xYUd0fT7; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:60152 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l788w-0001oK-Lm for alex.bennee@linaro.org; Tue, 02 Feb 2021 21:43:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l785c-0008Lv-3n for qemu-devel@nongnu.org; Tue, 02 Feb 2021 21:40:21 -0500 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:41314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l785a-0000Vh-6F for qemu-devel@nongnu.org; Tue, 02 Feb 2021 21:40:19 -0500 Received: by mail-pf1-x430.google.com with SMTP id q20so15685501pfu.8 for ; Tue, 02 Feb 2021 18:40:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OQUXtjjBRqzQtTa2aivLBliJb+EH57HgyvLFb4ZVM0I=; b=xYUd0fT7dC/6xwCjSZoS5+9NSWxX/Fdbeqx49bZq6j2rXnPTl9zGW5vU/jGNbnQ8eu lnc69Re4OrK8ubDvxLDHhKqaZ4uvSge4Znr4+uJuAXTDnEpIKTzaYQanHa+5sPPHFTz4 gtC7mQBN0pgjTiZt0UQYq0oSqHT8UqrBSC/kTIqUryWaqeBINT9G7TqxTxUJS7Dxfz6N NuHw8AszfrylPadOnVM8kiz+81t5MhieWDBYQ/Ka+FJXqj2llHxeEbkO8ACIrGPCE86v QA2F0Dt5YSeBvoEorn8965WRdeLoOrLyIqQLfrmq038ceov+rHWzMU5FRzBhExrV3zPk 3Esw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OQUXtjjBRqzQtTa2aivLBliJb+EH57HgyvLFb4ZVM0I=; b=fNHGXosfmfGxKj7bdg1hipwnEgvESnny5ZnVoor6lA07S9Z2/EHP4VHiA7n60G3XP7 U8JWFkuqVq9GbsLdUuTPiImeGYvZanrY1bu9oqX2oofw1Tby6NDj3/Br3vpREcRx69j4 K25p5XKnP6Sw6bcsv+m1HoZJyE+GioVmH+jdctpJM4gBnyn6WDSSeO0XO55pNqOG88Ge Cfen7as56D5Rf2zh0P2jhRpGncDbl6QQKr3Jr00/+oFDA+2WKYgwXSTUzRQPbQk8Czfa ojHcWMLEvcz5X+Rz7MAl47UzLPDq2BgL8wf1khfPRxXBl8ZLYZZ/h7Feq9dOyw3+e+9B zCMQ== X-Gm-Message-State: AOAM532E2CRM2o9BH24c8p7E9RUHZJdtsPcnL9/1VFNZlPeDuOk0e7WT eySRLOfP9nUpTE4wYNtRyO/fEQ== X-Received: by 2002:aa7:99db:0:b029:1ba:5263:63c4 with SMTP id v27-20020aa799db0000b02901ba526363c4mr961523pfi.53.1612320016448; Tue, 02 Feb 2021 18:40:16 -0800 (PST) Received: from [192.168.3.43] (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id a2sm272526pjm.51.2021.02.02.18.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Feb 2021 18:40:15 -0800 (PST) Subject: Re: [PATCH v4 01/23] tcg: Introduce target-specific page data for user-only To: Peter Maydell References: <20210128224141.638790-1-richard.henderson@linaro.org> <20210128224141.638790-2-richard.henderson@linaro.org> From: Richard Henderson Message-ID: Date: Tue, 2 Feb 2021 16:40:12 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.155, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: zae0akN+JP/V On 2/2/21 4:29 AM, Peter Maydell wrote: > On Thu, 28 Jan 2021 at 22:41, Richard Henderson > wrote: >> >> This data can be allocated by page_alloc_target_data() and >> released by page_set_flags(start, end, prot | PAGE_RESET). >> >> This data will be used to hold tag memory for AArch64 MTE. >> >> Signed-off-by: Richard Henderson >> --- >> v3: Add doc comments; tweak alloc so that the !PAGE_VALID case is clear. >> --- >> include/exec/cpu-all.h | 42 +++++++++++++++++++++++++++++++++------ >> accel/tcg/translate-all.c | 28 ++++++++++++++++++++++++++ >> linux-user/mmap.c | 4 +++- >> linux-user/syscall.c | 4 ++-- >> 4 files changed, 69 insertions(+), 9 deletions(-) > > I reviewed this (and some of the other patches) in v3, but > you didn't pick up the tags :-( > > Here it is again: > Reviewed-by: Peter Maydell Well, here's the thing: this appears to be v3, reposted. All of the work I did for v4 has gone missing. I went to go fix the single use of current_cpu, and it wasn't where I expected it to be, and that's when I noticed. I'm grepping blobs now, but I must have made some horrible git error. :-( r~