From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 10.223.172.38 with SMTP id v35csp707289wrc; Fri, 15 Sep 2017 06:19:58 -0700 (PDT) X-Google-Smtp-Source: AOwi7QDFKAKKDVndyjGhzFwZLEO/Sg8hMfoJCBUR7PVSAxKMtqwTQhkAzsphI+yBM+23Jgl554yb X-Received: by 10.55.81.215 with SMTP id f206mr7520373qkb.188.1505481598802; Fri, 15 Sep 2017 06:19:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505481598; cv=none; d=google.com; s=arc-20160816; b=jCFC7HuERRwBYTl67UNspiVrW+CNTsNbrbDft5MGquO5DLwgqE1Mu/c/Aopz+1l+S5 uaLYu8Wm1C4YYz+EfhOPJs87ohFG6KtVaIWU/5RT5fTo5CoMVsBroInB+Gsd/Nmq6dj3 Mi+VIrIlLnZHRvEoQo2jieOSx6qnbR0OpGtqOQNyYf2y6Pxd1ggvxyop0fU7uciky0nw L9zjmFc3WLylxk6FstkPiUtTnQpHtPVq+KkL3YFPvSn82aM3c1rAzORh2goyBu84/CLb XkrT/7vVKycyLt3HwgcM8HRAUqhpkAiJANgZ+R2bXpDNJ1mGE/DqIHiarMN3Ew2Ko5K3 OcRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:dmarc-filter :arc-authentication-results; bh=YGMhIqMXIEf4Y2NPNLU0uqs+5ulgsdcWnc2iyPdgfUg=; b=CHVEj6jzgP8Tc+1loqze/3BkLtTKc7nG4wYmJBuiwl4bQhNcJED/Eh89G/N2NIaYS9 KXfTZ7hm2mtgVyljMOfF5F9qpI7+ehiL16PJM7BfFqO+wahocqOfi94XxRk9oR9aVt9Q PxXmk+FdePOK2ah6HSYghzFjTqbBKgAYUCN3JWZ+CsRChoN1EOkxy2nJW5FqKxyejxdw olVTcujBEXoQ/3r3B9hMu1mIi4mg1OUrgVaL2yk2Xd2CKXxQMOsfA04go4ylDvPUMb1N 930/mdY5+LjCm/1HGpJyKwlWd2zs56/4DL1cV4iXcHHGnORnMvNck2QJdqaUFF2uScrg LaHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id s30si928022qtb.370.2017.09.15.06.19.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 15 Sep 2017 06:19:58 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:53368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsqXE-0006EC-FP for alex.bennee@linaro.org; Fri, 15 Sep 2017 09:19:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsqX0-0006Bk-On for qemu-arm@nongnu.org; Fri, 15 Sep 2017 09:19:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsqWx-00061k-FI for qemu-arm@nongnu.org; Fri, 15 Sep 2017 09:19:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41272) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsqWx-00061Y-6c; Fri, 15 Sep 2017 09:19:39 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2948981DFC; Fri, 15 Sep 2017 13:19:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2948981DFC Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=eric.auger@redhat.com Received: from localhost.localdomain (ovpn-116-217.ams2.redhat.com [10.36.116.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC130757BC; Fri, 15 Sep 2017 13:19:27 +0000 (UTC) To: tn , Tomasz Nowicki , Linu Cherian References: <1504286483-23327-1-git-send-email-eric.auger@redhat.com> <1504286483-23327-14-git-send-email-eric.auger@redhat.com> <20170914092751.GA3336@virtx40> <4dbbccae-64e1-f4ac-4dcc-3abd9766f324@caviumnetworks.com> <795d99ba-e492-04ce-dda4-709682baf6cd@caviumnetworks.com> <4f9fc697-9e6c-5dd7-65c7-92326135aa56@redhat.com> From: Auger Eric Message-ID: Date: Fri, 15 Sep 2017 15:19:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 15 Sep 2017 13:19:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, drjones@redhat.com, tcain@qti.qualcomm.com, Radha.Chintakuntla@cavium.com, Sunil.Goutham@cavium.com, mohun106@gmail.com, jean-philippe.brucker@arm.com, bharat.bhushan@nxp.com, mst@redhat.com, will.deacon@arm.com, qemu-devel@nongnu.org, peterx@redhat.com, alex.williamson@redhat.com, qemu-arm@nongnu.org, christoffer.dall@linaro.org, linu.cherian@cavium.com, wtownsen@redhat.com, robin.murphy@arm.com, prem.mallappa@gmail.com, eric.auger.pro@gmail.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 2U05rYJnPhY8 Hi Tomasz, On 15/09/2017 12:42, tn wrote: > Hi Eric, > > On 15.09.2017 09:30, Auger Eric wrote: >> Hi Tomasz, >> >> On 14/09/2017 16:43, Tomasz Nowicki wrote: >>> On 14.09.2017 16:31, Tomasz Nowicki wrote: >>>> Hi Eric, >>>> >>>> On 14.09.2017 11:27, Linu Cherian wrote: >>>>> Hi Eric, >>>>> >>>>> On Fri Sep 01, 2017 at 07:21:16PM +0200, Eric Auger wrote: >>>>>> memory_region_iommu_replay() is used for VFIO integration. >>>>>> >>>>>> However its default implementation is not adapted to SMMUv3 >>>>>> IOMMU memory region. Indeed the input address range is too >>>>>> huge and its execution is too slow as it calls the translate() >>>>>> callback on each granule. >>>>>> >>>>>> Let's implement the replay callback which hierarchically walk >>>>>> over the page table structure and notify only the segments >>>>>> that are populated with valid entries. >>>>>> >>>>>> Signed-off-by: Eric Auger >>>>>> --- >>>>>> hw/arm/smmuv3.c | 36 ++++++++++++++++++++++++++++++++++++ >>>>>> hw/arm/trace-events | 1 + >>>>>> 2 files changed, 37 insertions(+) >>>>>> >>>>>> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c >>>>>> index 8e7d10d..c43bd93 100644 >>>>>> --- a/hw/arm/smmuv3.c >>>>>> +++ b/hw/arm/smmuv3.c >>>>>> @@ -657,6 +657,41 @@ static int smmuv3_notify_entry(IOMMUTLBEntry >>>>>> *entry, void *private) >>>>>> return 0; >>>>>> } >>>>>> +/* Unmap the whole notifier's range */ >>>>>> +static void smmuv3_unmap_notifier_range(IOMMUNotifier *n) >>>>>> +{ >>>>>> + IOMMUTLBEntry entry; >>>>>> + hwaddr size = n->end - n->start + 1; >>>>>> + >>>>>> + entry.target_as = &address_space_memory; >>>>>> + entry.iova = n->start & ~(size - 1); >>>>>> + entry.perm = IOMMU_NONE; >>>>>> + entry.addr_mask = size - 1; >>>>>> + >>>>>> + memory_region_notify_one(n, &entry); >>>>>> +} >>>>>> + >>>>>> +static void smmuv3_replay(IOMMUMemoryRegion *mr, IOMMUNotifier *n) >>>>>> +{ >>>>>> + SMMUTransCfg cfg = {}; >>>>>> + int ret; >>>>>> + >>>>>> + trace_smmuv3_replay(mr->parent_obj.name, n, n->start, n->end); >>>>>> + smmuv3_unmap_notifier_range(n); >>>>>> + >>>>>> + ret = smmuv3_decode_config(mr, &cfg); >>>>>> + if (ret) { >>>>>> + error_report("%s error decoding the configuration for iommu >>>>>> mr=%s", >>>>>> + __func__, mr->parent_obj.name); >>>>>> + } >>>>>> >>>>> >>>>> On an invalid config being found, shouldnt we return rather than >>>>> proceeding with >>>>> page table walk. For example on an invalid Stream table entry. >>>> >>>> Indeed, without return here vhost case is not working for me. >>> >>> I was just lucky one time. return here has no influence. Vhost still not >>> working. Sorry for noise. >> >> As far as I understand the replay() callback only is called in VFIO use >> case. So this shouldn't impact vhost. >> >> I can't reproduce your vhost issue on my side. I will review the >> invalidate code again and compare against the last version. >> >> What is the page size used by your guest? > > 64K page size for guest as well as for host. > > However, I've just checked 4K page size for guest and then vhost is > working fine. I can reproduce the issue with vhost on 64KB page guest. Currently investigating... Thanks! Eric > > Thanks, > Tomasz