* [PATCH] qom/object.c: Fix typo
@ 2021-02-12 0:56 Doug Evans via
2021-02-12 9:38 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Doug Evans via @ 2021-02-12 0:56 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
A simple typo (noticed by inspection).
commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee
Author: Doug Evans <dje@google.com>
Date: Thu Feb 11 16:29:13 2021 -0800
qom/object.c: Fix typo
Signed-off-by: Doug Evans <dje@google.com>
diff --git a/qom/object.c b/qom/object.c
index 491823db4a..6a01d56546 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -695,7 +695,7 @@ static void object_finalize(void *data)
/* Find the minimum alignment guaranteed by the system malloc. */
#if __STDC_VERSION__ >= 201112L
-typddef max_align_t qemu_max_align_t;
+typedef max_align_t qemu_max_align_t;
#else
typedef union {
long l;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] qom/object.c: Fix typo
2021-02-12 0:56 [PATCH] qom/object.c: Fix typo Doug Evans via
@ 2021-02-12 9:38 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-12 9:38 UTC (permalink / raw)
To: Doug Evans, Paolo Bonzini; +Cc: qemu-devel
Hi Doug,
On 2/12/21 1:56 AM, Doug Evans via wrote:
> A simple typo (noticed by inspection).
>
> commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee
> Author: Doug Evans <dje@google.com>
> Date: Thu Feb 11 16:29:13 2021 -0800
>
> qom/object.c: Fix typo
>
> Signed-off-by: Doug Evans <dje@google.com>
Your patch can be applied with git-am, but with author
Doug Evans via <qemu-devel@nongnu.org> and contains an invalid
commit reference.
Can you use git-format-patch which inserts a From: tag so your
email is properly set and you don't have to worry with the issues
with your email provider:
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch
> diff --git a/qom/object.c b/qom/object.c
> index 491823db4a..6a01d56546 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -695,7 +695,7 @@ static void object_finalize(void *data)
>
> /* Find the minimum alignment guaranteed by the system malloc. */
> #if __STDC_VERSION__ >= 201112L
> -typddef max_align_t qemu_max_align_t;
> +typedef max_align_t qemu_max_align_t;
> #else
> typedef union {
> long l;
>
For the typo:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-12 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-12 0:56 [PATCH] qom/object.c: Fix typo Doug Evans via
2021-02-12 9:38 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).