From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40266) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmwi3-0000dE-9k for qemu-devel@nongnu.org; Thu, 22 Sep 2016 01:38:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmwhx-0004IE-MQ for qemu-devel@nongnu.org; Thu, 22 Sep 2016 01:38:11 -0400 Received: from mail.ispras.ru ([83.149.199.45]:44232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmwhx-0004Ex-EC for qemu-devel@nongnu.org; Thu, 22 Sep 2016 01:38:05 -0400 From: "Pavel Dovgalyuk" References: <20160921113303.1420.63544.stgit@PASHA-ISP.def.inno> <20160921113315.1420.49751.stgit@PASHA-ISP.def.inno> <5d38dfa7-8a5f-a324-ad22-cdd56d288697@redhat.com> <004901d2141f$af552420$0dff6c60$@ru> <8327862c-32c6-23ad-38b2-eb7fd9cd25cc@redhat.com> In-Reply-To: <8327862c-32c6-23ad-38b2-eb7fd9cd25cc@redhat.com> Date: Thu, 22 Sep 2016 08:37:47 +0300 Message-ID: <000001d21493$748b4d00$5da1e700$@ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH v4 2/8] replay: save/load initial state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , 'Pavel Dovgalyuk' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, jasowang@redhat.com, quintela@redhat.com, mst@redhat.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 21/09/2016 17:49, Pavel Dovgalyuk wrote: > >> From: Paolo Bonzini [mailto:pbonzini@redhat.com] > >> On 21/09/2016 13:33, Pavel Dovgalyuk wrote: > >>> +New VM snapshots may be created in replay mode. They can be used later > >>> +to recover the desired VM state. All VM states created in replay mode > >>> +are associated with the moment of time in the replay scenario. > >>> +After recovering the VM state replay will start from that position. > >>> + > >>> +Default starting snapshot name may be specified with icount field > >>> +rrsnapshot as follows: > >>> + -icount shift=7,rr=record,rrfile=replay.bin,rrsnapshot=snapshot_name > >>> + > >>> +This snapshot is created at start of recording and restored at start > >>> +of replaying. It also can be loaded while replaying to roll back > >>> +the execution. > >> > >> Should you mention somewhere that you need -snapshot for raw images? > > > > Do you mean when rrsnapshot is used with raw images? > > I mean that (if I understand correctly) raw images are corrupted if you > don't use -snapshot (the record overwrites them, and the replay reads > overwritten data). I tried running record/replay with raw image. Record finished without an error, but replay couldn't start, because there was no snapshot to load. I think the solution is checking savevm return code and exiting if snapshot cannot be created. Pavel Dovgalyuk