From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Artem Pisarenko' <artem.k.pisarenko@gmail.com>
Cc: 'Paolo Bonzini' <pbonzini@redhat.com>,
'Clement Deschamps' <clement.deschamps@greensocs.com>,
qemu-devel@nongnu.org,
'Pavel Dovgalyuk' <Pavel.Dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call"
Date: Thu, 18 Oct 2018 08:49:43 +0300 [thread overview]
Message-ID: <000001d466a6$5e940430$1bbc0c90$@ru> (raw)
In-Reply-To: <CANzW0mtAh9vjWa-TAdB60b1kvyN_3O07kbyvFzYO_eL6sNjHQQ@mail.gmail.com>
I made a fix to ensure that QBox patch doesn’t break the replay.
Now I tried it on couple of tests and didn’t see any regression.
Pavel Dovgalyuk
From: Artem Pisarenko [mailto:artem.k.pisarenko@gmail.com]
Sent: Wednesday, October 17, 2018 4:32 PM
To: Pavel Dovgalyuk
Cc: Paolo Bonzini; Clement Deschamps; qemu-devel@nongnu.org; Pavel Dovgalyuk
Subject: Re: [PATCH] Revert "icount: remove obsolete warp call"
> I found the source of the bug. As QEMU becomes more multi-threaded and non-> synchronized,
> checkpoints move from thread to thread.
> And the event queue that processed at checkpoints should belong to the same thread
> in both record and replay executions.
>
> Current problem was with the checkpoint for virtual timers. They are processed from different threads:
> from vCPU and from aio_dispatch function.
What bug you're talking about ? This patch thread started with intention to fix generic bug with icount, which is being encountered in non-rr mode. As far as I understood your words (and patch content) it will not fix that generic bug.
Anyway, it's a good news!
--
С уважением,
Артем Писаренко
next prev parent reply other threads:[~2018-10-18 5:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 9:07 [Qemu-devel] [PATCH] Revert "icount: remove obsolete warp call" Paolo Bonzini
2018-10-17 9:37 ` Pavel Dovgalyuk
2018-10-17 9:53 ` Artem Pisarenko
2018-10-17 10:17 ` Paolo Bonzini
2018-10-17 11:38 ` Pavel Dovgalyuk
2018-10-17 11:42 ` Paolo Bonzini
2018-10-17 11:43 ` Pavel Dovgalyuk
2018-10-17 12:30 ` Alex Bennée
2018-10-17 12:11 ` Pavel Dovgalyuk
2018-10-17 13:20 ` Pavel Dovgalyuk
2018-10-17 13:32 ` Artem Pisarenko
2018-10-18 5:49 ` Pavel Dovgalyuk [this message]
2018-10-17 14:43 ` Paolo Bonzini
2018-10-18 2:22 ` Clement Deschamps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d466a6$5e940430$1bbc0c90$@ru' \
--to=dovgaluk@ispras.ru \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=artem.k.pisarenko@gmail.com \
--cc=clement.deschamps@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).