From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Kevin Wolf' <kwolf@redhat.com>
Cc: pbonzini@redhat.com, 'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
quintela@redhat.com, jasowang@redhat.com, mst@redhat.com,
mreitz@redhat.com, qemu-block@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters
Date: Thu, 22 Dec 2016 09:58:11 +0300 [thread overview]
Message-ID: <000401d25c20$c23be620$46b3b260$@ru> (raw)
In-Reply-To: <20161205124457.GB4870@noname.redhat.com>
Kevin,
> From: Kevin Wolf [mailto:kwolf@redhat.com]
> Am 05.12.2016 um 12:49 hat Pavel Dovgalyuk geschrieben:
> > > From: Kevin Wolf [mailto:kwolf@redhat.com]
> >
> > It's not a requirement. But to make replay deterministic we have to
> > start with the same image every time. As I know, this may be achieved by:
> > 1. Restoring original disk image manually
> > 2. Using vm snapshot to start execution from
> > 3. Using -snapshot option
> > 4. Not using disks at all
> >
> > > Because if it has to be
> > > there, the next step could be that blkreplay creates temporary-overlay
> > > internally in its .bdrv_open().
> >
> > Here is your answer about such an approach :)
> > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg04687.html
>
> Right, and unfortunately these are still good points.
>
> Especially the part where you allowed to give the overlay filename
> really needs to work the way it does now with the 'image' option. We
> might not need to be that strict with temporary overlays, restricting to
> qcow2 with default options could be acceptable there - but whatever I
> think of to support both cases results in something that isn't really
> easier than the manual way that we figured out above.
What about the new version?
Pavel Dovgalyuk
next prev parent reply other threads:[~2016-12-22 6:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 8:07 [Qemu-devel] [PATCH v5 0/9] replay additions Pavel Dovgalyuk
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 1/9] replay: move internal data to the structure Pavel Dovgalyuk
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 2/9] replay: vmstate for replay module Pavel Dovgalyuk
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 3/9] replay: allow replay stopping and restarting Pavel Dovgalyuk
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 4/9] record/replay: add network support Pavel Dovgalyuk
2016-10-27 3:36 ` Jason Wang
2016-10-27 7:58 ` Paolo Bonzini
2016-10-31 7:41 ` Jason Wang
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 5/9] savevm: add public save_vmstate function Pavel Dovgalyuk
2016-09-26 8:15 ` Paolo Bonzini
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 6/9] replay: save/load initial state Pavel Dovgalyuk
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters Pavel Dovgalyuk
2016-09-26 9:23 ` Kevin Wolf
2016-09-26 9:51 ` Pavel Dovgalyuk
2016-09-26 13:17 ` Kevin Wolf
2016-09-27 14:06 ` Pavel Dovgalyuk
2016-09-28 8:36 ` Kevin Wolf
2016-09-28 9:32 ` Pavel Dovgalyuk
2016-09-28 9:43 ` Kevin Wolf
2016-09-28 12:49 ` Pavel Dovgalyuk
2016-09-29 10:32 ` Kevin Wolf
2016-11-16 9:49 ` Pavel Dovgalyuk
2016-11-16 12:15 ` Paolo Bonzini
2016-11-16 13:50 ` Pavel Dovgalyuk
2016-11-16 12:20 ` Kevin Wolf
2016-11-21 12:22 ` Pavel Dovgalyuk
2016-11-21 15:54 ` Kevin Wolf
2016-12-05 7:43 ` Pavel Dovgalyuk
2016-12-05 10:34 ` Kevin Wolf
2016-12-05 11:49 ` Pavel Dovgalyuk
2016-12-05 12:44 ` Kevin Wolf
2016-12-06 9:37 ` Pavel Dovgalyuk
2016-12-22 6:58 ` Pavel Dovgalyuk [this message]
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 8/9] block: implement bdrv_recurse_is_first_non_filter for blkreplay Pavel Dovgalyuk
2016-09-26 8:08 ` [Qemu-devel] [PATCH v5 9/9] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2016-09-26 8:15 ` [Qemu-devel] [PATCH v5 0/9] replay additions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401d25c20$c23be620$46b3b260$@ru' \
--to=dovgaluk@ispras.ru \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).