From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Samuel Thibault' <samuel.thibault@gnu.org>,
'Pavel Dovgalyuk' <Pavel.Dovgaluk@ispras.ru>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com,
peter.maydell@linaro.org, war2jordan@live.com,
pbonzini@redhat.com, quintela@redhat.com,
ciro.santilli@gmail.com, jasowang@redhat.com,
crosthwaite.peter@gmail.com, zuban32s@gmail.com,
armbru@redhat.com, maria.klimushenkova@ispras.ru, mst@redhat.com,
kraxel@redhat.com, boost.lists@gmail.com,
thomas.dullien@googlemail.com, mreitz@redhat.com,
alex.bennee@linaro.org, dgilbert@redhat.com, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers
Date: Thu, 26 Jul 2018 10:08:29 +0300 [thread overview]
Message-ID: <000601d424af$74e5c900$5eb15b00$@ru> (raw)
In-Reply-To: <20180725134429.roe7iuzakjywdv7e@var.youpi.perso.aquilenet.fr>
> From: Samuel Thibault [mailto:samuel.thibault@gnu.org]
> Pavel Dovgalyuk, le mer. 25 juil. 2018 15:17:06 +0300, a ecrit:
> > ICMP implementation for IPv6 uses timers based on virtual clock.
> > This is incorrect because this service is not related to the guest state.
>
> ? Why not? The RAs are seen by the guest.
Because virtual clock should be used by the virtual devices.
slirp module is not the virtual device. Therefore processed packets
become visible to the guest after passing to the virtual network card.
Before that it can create any timers that should not change the state of the guest.
> As documented:
>
> * @QEMU_CLOCK_REALTIME: Real time clock
> *
> * The real time clock should be used only for stuff which does not
> * change the virtual machine state, as it runs even if the virtual
> * machine is stopped.
>
> There is no reason to "send RAs" while the machine is stopped.
I see.
Then we'll need one more clock. Which works like realtime+virtual:
intended to be used for the internal QEMU purposes, but stops when
VM is stopped.
Pavel Dovgalyuk
next prev parent reply other threads:[~2018-07-26 7:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 12:13 [Qemu-devel] [PATCH v5 00/24] Fixing record/replay and adding reverse debugging Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 01/24] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 02/24] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 03/24] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 04/24] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 05/24] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 06/24] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2018-07-25 12:13 ` [Qemu-devel] [PATCH v5 07/24] migration: " Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 08/24] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2018-07-25 14:56 ` Dr. David Alan Gilbert
2018-07-31 6:54 ` Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 09/24] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 10/24] replay: implement replay-seek command to proceed to the desired step Pavel Dovgalyuk
2018-07-25 12:14 ` [Qemu-devel] [PATCH v5 11/24] replay: flush events when exiting Pavel Dovgalyuk
2018-07-25 12:15 ` [Qemu-devel] [PATCH v5 12/24] timer: remove replay clock probe in deadline calculation Pavel Dovgalyuk
2018-07-25 12:15 ` [Qemu-devel] [PATCH v5 13/24] replay: refine replay-time module Pavel Dovgalyuk
2018-07-25 12:15 ` [Qemu-devel] [PATCH v5 14/24] translator: fix breakpoint processing Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 15/24] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 16/24] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 17/24] gdbstub: add reverse continue " Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 18/24] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 19/24] replay: allow loading any snapshots before recording Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 20/24] ps2: prevent changing irq state on save and load Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 21/24] replay: wake up vCPU when replaying Pavel Dovgalyuk
2018-07-25 12:16 ` [Qemu-devel] [PATCH v5 22/24] replay: replay BH for IDE trim operation Pavel Dovgalyuk
2018-07-25 12:29 ` Paolo Bonzini
2018-07-25 12:17 ` [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer Pavel Dovgalyuk
2018-07-26 15:36 ` Alex Bennée
2018-07-26 17:20 ` Alex Bennée
2018-07-27 4:52 ` Pavel Dovgalyuk
2018-07-27 16:44 ` Alex Bennée
2018-08-02 5:50 ` Pavel Dovgalyuk
2018-07-26 17:17 ` Alex Bennée
2018-07-31 7:00 ` Pavel Dovgalyuk
2018-08-01 16:54 ` Paolo Bonzini
2018-07-25 12:17 ` [Qemu-devel] [PATCH v5 24/24] slirp: fix ipv6 timers Pavel Dovgalyuk
2018-07-25 13:44 ` Samuel Thibault
2018-07-26 7:08 ` Pavel Dovgalyuk [this message]
2018-07-26 7:35 ` Samuel Thibault
2018-07-26 7:37 ` Pavel Dovgalyuk
2018-07-26 7:40 ` Samuel Thibault
2018-07-26 8:07 ` Samuel Thibault
2018-07-26 8:37 ` Pavel Dovgalyuk
2018-07-26 9:15 ` Samuel Thibault
2018-07-31 6:58 ` Pavel Dovgalyuk
2018-08-01 19:22 ` Samuel Thibault
2018-07-25 14:15 ` [Qemu-devel] [PATCH v5 00/24] Fixing record/replay and adding reverse debugging no-reply
2018-08-07 23:13 ` Ciro Santilli
2018-09-12 8:14 ` dovgaluk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000601d424af$74e5c900$5eb15b00$@ru' \
--to=dovgaluk@ispras.ru \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=samuel.thibault@gnu.org \
--cc=thomas.dullien@googlemail.com \
--cc=war2jordan@live.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).