From: "Mike Nordell" <tamlin@algonet.se>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] WinXP mouse patch
Date: Fri, 16 Apr 2004 07:17:24 +0200 [thread overview]
Message-ID: <000701c42372$1b555e80$0401a8c0@putte2k> (raw)
Mark Jonckheere wrote:
> The following patch against the latest CVS (13 april) resolved
> for me the slow mouse movements in WinXP.
Looking at it, I see difference between hosts and do one observation.
The difference is that QEMU on Win32 isn't as far as I have observed or
experienced plagued by this problem. The observation is that if SDL did its
job, this patch would be "dead code" - a code path never taken, why it seems
to me to be an SDL problem/bug related to your specific host OS. Could you
verify this?
I base that observation on the fact that kbd_mouse_event() should only be
called from sdl_send_mouse_event() in sdl.c, which in turn should only be
called when an SDL event of type SDL_MOUSEMOTION, SDL_MOUSEBUTTONDOWN or
SDL_MOUSEBUTTONUP is recieved. If you get SDL_MOUSEMOTION with with dx&dy =
0 from SDL_GetRelativeMouseState, I can't see any other explanation than an
SDL problem.
That said, since it apparently solves a real problem I too think the patch
should be included, with the addition of a comment explaining why that code
is there.
/Mike
next reply other threads:[~2004-04-16 5:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 5:17 Mike Nordell [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-04-15 22:59 [Qemu-devel] WinXP mouse patch Mark Jonckheere
2004-04-16 22:55 ` Gregory Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000701c42372$1b555e80$0401a8c0@putte2k' \
--to=tamlin@algonet.se \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).