From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BELjN-0006tI-DX for qemu-devel@nongnu.org; Fri, 16 Apr 2004 01:17:37 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BELir-0006XG-K3 for qemu-devel@nongnu.org; Fri, 16 Apr 2004 01:17:36 -0400 Received: from [81.228.11.113] (helo=av7-1-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BELiq-0006XB-Sg for qemu-devel@nongnu.org; Fri, 16 Apr 2004 01:17:05 -0400 Received: from smtp3-2-sn1.fre.skanova.net (smtp3-2-sn1.fre.skanova.net [81.228.11.164]) by av7-1-sn1.fre.skanova.net (Postfix) with ESMTP id 3A93637E43 for ; Fri, 16 Apr 2004 07:17:04 +0200 (CEST) Received: from putte2k (h151n2fls306o994.telia.com [81.225.243.151]) by smtp3-2-sn1.fre.skanova.net (Postfix) with SMTP id 203B837E4C for ; Fri, 16 Apr 2004 07:17:04 +0200 (CEST) Message-ID: <000701c42372$1b555e80$0401a8c0@putte2k> From: "Mike Nordell" Subject: Re: [Qemu-devel] WinXP mouse patch Date: Fri, 16 Apr 2004 07:17:24 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Mark Jonckheere wrote: > The following patch against the latest CVS (13 april) resolved > for me the slow mouse movements in WinXP. Looking at it, I see difference between hosts and do one observation. The difference is that QEMU on Win32 isn't as far as I have observed or experienced plagued by this problem. The observation is that if SDL did its job, this patch would be "dead code" - a code path never taken, why it seems to me to be an SDL problem/bug related to your specific host OS. Could you verify this? I base that observation on the fact that kbd_mouse_event() should only be called from sdl_send_mouse_event() in sdl.c, which in turn should only be called when an SDL event of type SDL_MOUSEMOTION, SDL_MOUSEBUTTONDOWN or SDL_MOUSEBUTTONUP is recieved. If you get SDL_MOUSEMOTION with with dx&dy = 0 from SDL_GetRelativeMouseState, I can't see any other explanation than an SDL problem. That said, since it apparently solves a real problem I too think the patch should be included, with the addition of a comment explaining why that code is there. /Mike