From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Paolo Bonzini' <pbonzini@redhat.com>,
'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com,
jasowang@redhat.com, mst@redhat.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v7 05/14] apic: save apic_delivered flag
Date: Wed, 25 Jan 2017 16:01:11 +0300 [thread overview]
Message-ID: <000a01d2770b$1ab2d980$50188c80$@ru> (raw)
In-Reply-To: <1cab1a55-15cf-e9dc-f137-e55b613bd090@redhat.com>
> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> On 25/01/2017 12:52, Pavel Dovgalyuk wrote:
> >> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini
> >> On 24/01/2017 08:17, Pavel Dovgalyuk wrote:
> >>> This patch implements saving/restoring of static apic_delivered variable.
> >>>
> >>> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> >>> ---
> >>> hw/intc/apic_common.c | 32 ++++++++++++++++++++++++++++++++
> >>> include/hw/i386/apic_internal.h | 2 ++
> >>> 2 files changed, 34 insertions(+)
> >>>
> >>> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> >>> index d78c885..ac6cc67 100644
> >>> --- a/hw/intc/apic_common.c
> >>> +++ b/hw/intc/apic_common.c
> >>> @@ -384,6 +384,24 @@ static bool apic_common_sipi_needed(void *opaque)
> >>> return s->wait_for_sipi != 0;
> >>> }
> >>>
> >>> +static bool apic_irq_delivered_needed(void *opaque)
> >>> +{
> >>> + return true;
> >>
> >> Is it needed for CPUs except the first (or the last?)?
> >>
> >
> > As this is global variable, it is needed only for one CPU.
> > Do you mean that APIC state is saved for every CPU?
>
> Yes, each CPU has its own APIC.
How to link this data to a single CPU?
Pavel Dovgalyuk
next prev parent reply other threads:[~2017-01-25 13:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 7:16 [Qemu-devel] [PATCH v7 00/14] replay additions Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 01/14] icount: update instruction counter on apic patching Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 02/14] replay: improve interrupt handling Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 03/14] replay: exception replay fix Pavel Dovgalyuk
2017-01-25 10:50 ` Paolo Bonzini
2017-01-25 11:12 ` Pavel Dovgalyuk
2017-01-25 11:18 ` Paolo Bonzini
2017-01-25 11:33 ` Pavel Dovgalyuk
2017-01-25 11:56 ` Paolo Bonzini
2017-01-25 12:27 ` Pavel Dovgalyuk
2017-01-25 13:21 ` Paolo Bonzini
2017-01-25 13:26 ` Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 04/14] icount: exit cpu loop on expire Pavel Dovgalyuk
2017-01-25 11:06 ` Paolo Bonzini
2017-01-25 11:50 ` Pavel Dovgalyuk
2017-01-25 12:00 ` Paolo Bonzini
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 05/14] apic: save apic_delivered flag Pavel Dovgalyuk
2017-01-25 11:07 ` Paolo Bonzini
2017-01-25 11:52 ` Pavel Dovgalyuk
2017-01-25 11:57 ` Paolo Bonzini
2017-01-25 13:01 ` Pavel Dovgalyuk [this message]
2017-01-25 13:14 ` Paolo Bonzini
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 06/14] replay: don't use rtc clock on loadvm phase Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 07/14] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 08/14] savevm: add public save_vmstate function Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 09/14] replay: save/load initial state Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 10/14] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-01-24 7:17 ` [Qemu-devel] [PATCH v7 11/14] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-01-24 7:18 ` [Qemu-devel] [PATCH v7 12/14] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2017-01-24 7:18 ` [Qemu-devel] [PATCH v7 13/14] audio: make audio poll timer deterministic Pavel Dovgalyuk
2017-01-24 7:18 ` [Qemu-devel] [PATCH v7 14/14] replay: add record/replay for audio passthrough Pavel Dovgalyuk
2017-01-24 7:43 ` [Qemu-devel] [PATCH v7 00/14] replay additions no-reply
2017-01-25 11:12 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000a01d2770b$1ab2d980$50188c80$@ru' \
--to=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).