From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
To: 'Paolo Bonzini' <pbonzini@redhat.com>,
'Peter Maydell' <peter.maydell@linaro.org>,
'QEMU Developers' <qemu-devel@nongnu.org>
Cc: 'Richard Henderson' <rth@twiddle.net>
Subject: Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?
Date: Wed, 13 May 2015 09:57:23 +0300 [thread overview]
Message-ID: <000d01d08d4a$1059c7c0$310d5740$@Dovgaluk@ispras.ru> (raw)
In-Reply-To: <555243C8.30602@redhat.com>
> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini
> On 12/05/2015 17:32, Peter Maydell wrote:
> > In order for -icount to work, it's important for the target
> > translate.c code to correctly bracket any generated code which
> > can "do I/O" with gen_io_start()/gen_io_end() calls. But
> > does anybody know exactly what the criteria are here for this?
> > It would be nice if we could document this in a comment in
> > gen_icount.h -- I'm happy to write one up if somebody will just
> > tell me what the right answer is :-)
>
> It's any instruction that can cause an icount read, typically through
> QEMU_CLOCK_VIRTUAL or cpu_get_ticks().
Doesn't this mean that ARM has incorrect implementation of icount?
MMIO is common for this platform, but none of memory accesses are
surrounded with gen_io_start()/gen_io_end().
Pavel Dovgalyuk
next prev parent reply other threads:[~2015-05-13 6:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 15:32 [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ? Peter Maydell
2015-05-12 15:43 ` Richard Henderson
2015-05-12 15:54 ` Peter Maydell
2015-05-12 18:17 ` Paolo Bonzini
2015-05-12 19:41 ` Peter Maydell
2015-05-13 8:42 ` Paolo Bonzini
2015-05-13 9:41 ` Peter Maydell
2015-05-13 10:03 ` Paolo Bonzini
2015-05-13 12:30 ` Frederic Konrad
2015-05-13 6:57 ` Pavel Dovgaluk [this message]
[not found] ` <16201.3286528692$1431500273@news.gmane.org>
2015-05-13 8:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000d01d08d4a$1059c7c0$310d5740$@Dovgaluk@ispras.ru' \
--to=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).