From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Markus Armbruster' <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, 'Pavel Dovgalyuk' <Pavel.Dovgaluk@ispras.ru>
Subject: Re: [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI
Date: Mon, 31 Jul 2017 16:30:13 +0300 [thread overview]
Message-ID: <001101d30a01$247886c0$6d699440$@ru> (raw)
In-Reply-To: <87y3r43g2f.fsf@dusky.pond.sub.org>
> From: Markus Armbruster [mailto:armbru@redhat.com]
> "Pavel Dovgalyuk" <dovgaluk@ispras.ru> writes:
>
> >> From: Markus Armbruster [mailto:armbru@redhat.com]
> >> ReplayMode is defined in the QAPI schema, but not used there. Of the
> >> stuff QAPI generates for it only the typedef is actually used. Use of
> >> QAPI is pointless and only complicates things, so don't.
> >
> > This a bit useless now, but we plan to add more patches that include
> > QAPI commands for controlling and inspecting the record/replay process.
>
> I assume YAGNI until proven otherwise.
>
> Posting patches putting ReplayMode to use could serve as proof.
This is a sample of not yet included patch.
https://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg04278.html
Pavel Dovgalyuk
next prev parent reply other threads:[~2017-07-31 13:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 13:45 [Qemu-devel] [PATCH 0/3] Don't QAPI without need Markus Armbruster
2017-07-28 13:45 ` [Qemu-devel] [PATCH 1/3] replay: Define ReplayMode without QAPI Markus Armbruster
2017-07-31 6:59 ` Pavel Dovgalyuk
2017-07-31 13:13 ` Markus Armbruster
2017-07-31 13:30 ` Pavel Dovgalyuk [this message]
2017-07-28 13:45 ` [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode " Markus Armbruster
2017-07-28 17:17 ` Dr. David Alan Gilbert
2017-07-28 18:07 ` Eric Blake
2017-07-31 9:02 ` Markus Armbruster
2017-07-29 6:49 ` Hailiang Zhang
2017-07-28 13:45 ` [Qemu-devel] [PATCH 3/3] block: Remove unused BlockDeviceMapEntry Markus Armbruster
2017-07-28 18:10 ` Eric Blake
2017-12-15 13:13 ` Max Reitz
2017-07-28 18:10 ` [Qemu-devel] [PATCH 0/3] Don't QAPI without need Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101d30a01$247886c0$6d699440$@ru' \
--to=dovgaluk@ispras.ru \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).