qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix multiple qemu-options.def generation
Date: Fri, 14 Jan 2011 11:04:11 +0300	[thread overview]
Message-ID: <001201cbb3c1$a0b2e610$e218b230$@Dovgaluk@ispras.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

This patch fixes generation of multiple instances of qemu-options.def by
make script (at least for building in Windows).

Previous version had the following problem: you can built qemu, break the
contents of qemu-options.hx and build qemu successfully again.

Broken qemu-options.hx will not affect the build for the first time.

This works in both directions: after build was broken, you can fix
qemu-options.hx, but qemu will not build successfully, until you delete
qemu-options.def files.

 

Signed-off-by: Pavel Dovgaluk <pavel.dovgaluk@gmail.com>

---

Makefile.objs |    4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)

 

diff --git a/Makefile.objs b/Makefile.objs

index 4a1eaa1..ee9f190 100755

--- a/Makefile.objs

+++ b/Makefile.objs

@@ -269,10 +269,10 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS)

 vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS)

-vl.o: qemu-options.def

+vl.o: ../qemu-options.def

os-posix.o: qemu-options.def

os-win32.o: qemu-options.def

-qemu-options.def: $(SRC_PATH)/qemu-options.hx

+%qemu-options.def: $(SRC_PATH)/qemu-options.hx

               $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@,"
GEN   $(TARGET_DIR)$@")

-- 

1.7.3.3

 


[-- Attachment #2: Type: text/html, Size: 4452 bytes --]

             reply	other threads:[~2011-01-14  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14  8:04 Pavel Dovgaluk [this message]
     [not found] <-3044780617683472853@unknownmsgid>
2011-01-14  9:34 ` [Qemu-devel] [PATCH] Fix multiple qemu-options.def generation Stefan Hajnoczi
2011-01-14 11:24   ` Pavel Dovgaluk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001201cbb3c1$a0b2e610$e218b230$@Dovgaluk@ispras.ru' \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).