From: Paul Durrant <xadimgnik@gmail.com>
To: "'Philippe Mathieu-Daudé'" <f4bug@amsat.org>,
"'Markus Armbruster'" <armbru@redhat.com>,
qemu-devel@nongnu.org
Cc: "'Stefano Stabellini'" <sstabellini@kernel.org>,
"'Daniel P. Berrangé'" <berrange@redhat.com>,
"'Eduardo Habkost'" <ehabkost@redhat.com>,
"'Michael S. Tsirkin'" <mst@redhat.com>,
"'Laurent Vivier'" <laurent@vivier.eu>,
xen-devel@lists.xenproject.org,
"'Anthony Perard'" <anthony.perard@citrix.com>,
"'Paolo Bonzini'" <pbonzini@redhat.com>
Subject: RE: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error
Date: Mon, 21 Sep 2020 08:01:15 +0100 [thread overview]
Message-ID: <001401d68fe4$ffc9a990$ff5cfcb0$@xen.org> (raw)
In-Reply-To: <20200920114416.353277-3-f4bug@amsat.org>
> -----Original Message-----
> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On Behalf Of Philippe Mathieu-Daudé
> Sent: 20 September 2020 12:44
> To: Markus Armbruster <armbru@redhat.com>; qemu-devel@nongnu.org
> Cc: Laurent Vivier <laurent@vivier.eu>; Paolo Bonzini <pbonzini@redhat.com>; Anthony Perard
> <anthony.perard@citrix.com>; Stefano Stabellini <sstabellini@kernel.org>; Daniel P. Berrangé
> <berrange@redhat.com>; Eduardo Habkost <ehabkost@redhat.com>; Paul Durrant <paul@xen.org>; Marcel
> Apfelbaum <marcel.apfelbaum@gmail.com>; Michael S. Tsirkin <mst@redhat.com>; xen-
> devel@lists.xenproject.org; Philippe Mathieu-Daudé <f4bug@amsat.org>
> Subject: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error
>
> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize()
> with the ability to return a boolean value if an error occured,
> thus the caller does not need to check if the Error* pointer is
> set.
> Provide the same ability to the BusRealize type.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/qdev-core.h | 14 +++++++++++++-
> hw/hyperv/vmbus.c | 5 +++--
> hw/nubus/nubus-bus.c | 5 +++--
> hw/pci/pci.c | 12 +++++++++---
> hw/xen/xen-bus.c | 5 +++--
Acked-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2020-09-21 7:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 11:44 [PATCH 0/2] qdev: Let BusRealize() return a boolean value to indicate error Philippe Mathieu-Daudé
2020-09-20 11:44 ` [PATCH 1/2] qdev: Document qbus_realize() and qbus_unrealize() Philippe Mathieu-Daudé
2020-09-20 11:44 ` [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error Philippe Mathieu-Daudé
2020-09-21 7:01 ` Paul Durrant [this message]
2020-09-21 8:19 ` Markus Armbruster
2020-09-21 9:38 ` Philippe Mathieu-Daudé
2020-09-21 12:58 ` Markus Armbruster
2020-09-20 22:56 ` [PATCH 0/2] " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001401d68fe4$ffc9a990$ff5cfcb0$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).