From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
To: 'Richard Henderson' <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, leon.alrae@imgtec.com, agraf@suse.de,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions
Date: Mon, 6 Jul 2015 15:15:42 +0300 [thread overview]
Message-ID: <001601d0b7e5$7ae6e350$70b4a9f0$@Dovgaluk@ispras.ru> (raw)
In-Reply-To: <559A70EA.2040109@twiddle.net>
> From: Richard Henderson [mailto:rth7680@gmail.com] On Behalf Of Richard Henderson
> On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
> > This patch fixes exception handling for seg_helper functions.
> >
> > Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
>
>
> No, you don't want to discriminately change every call. That was my original
> point about not needing to change seg_helper.c or smm_helper.c.
>
> Further, any such changes would go along with the changes in translate.c to
> remove the state saving there.
>
> I would only change those that are "normal" memory operations, like fp loads
> etc. The segmentation changes are rare. The task state helpers require state
> saving anyway, so requiring a TCG search is a pessimization.
Then we'll have to stop the translation after every instruction that uses these function.
Is this a limited subset?
Pavel Dovgalyuk
next prev parent reply other threads:[~2015-07-06 12:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 8:25 [Qemu-devel] [PATCH v5 00/11] Fix exceptions handling for MIPS, PowerPC, and i386 Pavel Dovgalyuk
2015-07-06 8:25 ` [Qemu-devel] [PATCH v5 01/11] softmmu: add helper function to pass through retaddr Pavel Dovgalyuk
2015-07-06 10:22 ` Aurelien Jarno
2015-07-06 8:25 ` [Qemu-devel] [PATCH v5 02/11] cpu-exec: introduce loop exit with restore function Pavel Dovgalyuk
2015-07-06 10:22 ` Aurelien Jarno
2015-07-06 8:25 ` [Qemu-devel] [PATCH v5 03/11] target-mips: improve exceptions handling Pavel Dovgalyuk
2015-07-06 10:23 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 04/11] target-i386: introduce new raise_exception functions Pavel Dovgalyuk
2015-07-06 11:57 ` Richard Henderson
2015-07-06 12:12 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling for FPU instructions Pavel Dovgalyuk
2015-07-06 12:04 ` Richard Henderson
2015-07-06 12:42 ` Pavel Dovgaluk
[not found] ` <559a77d3.4e58980a.7a073.ffff997eSMTPIN_ADDED_BROKEN@mx.google.com>
2015-07-06 15:11 ` Richard Henderson
2015-07-06 12:12 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 06/11] target-i386: exception handling for div instructions Pavel Dovgalyuk
2015-07-06 12:04 ` Richard Henderson
2015-07-06 12:14 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 07/11] target-i386: exception handling for memory helpers Pavel Dovgalyuk
2015-07-06 12:07 ` Richard Henderson
2015-07-06 12:19 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions Pavel Dovgalyuk
2015-07-06 12:13 ` Richard Henderson
2015-07-06 12:15 ` Pavel Dovgaluk [this message]
2015-07-07 10:13 ` Pavel Dovgaluk
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 09/11] target-i386: exception handling for other helper functions Pavel Dovgalyuk
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 10/11] target-i386: remove useless PC updates Pavel Dovgalyuk
2015-07-06 12:21 ` Aurelien Jarno
2015-07-06 8:26 ` [Qemu-devel] [PATCH v5 11/11] target-ppc: exceptions handling in icount mode Pavel Dovgalyuk
2015-07-06 12:21 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001601d0b7e5$7ae6e350$70b4a9f0$@Dovgaluk@ispras.ru' \
--to=pavel.dovgaluk@ispras.ru \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).