From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1ZC5JO-0000Gz-Gr
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:15:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1ZC5JH-0003Bv-TA
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:15:50 -0400
Received: from mail.ispras.ru ([83.149.199.45]:59771)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1ZC5JH-00039i-MJ
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:15:43 -0400
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <20150706082535.11980.88013.stgit@PASHA-ISP>
	<20150706082622.11980.74680.stgit@PASHA-ISP>
	<559A70EA.2040109@twiddle.net>
In-Reply-To: <559A70EA.2040109@twiddle.net>
Date: Mon, 6 Jul 2015 15:15:42 +0300
Message-ID: <001601d0b7e5$7ae6e350$70b4a9f0$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling
	for seg_helper functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Richard Henderson' <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, leon.alrae@imgtec.com, agraf@suse.de, aurelien@aurel32.net

> From: Richard Henderson [mailto:rth7680@gmail.com] On Behalf Of Richard Henderson
> On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
> > This patch fixes exception handling for seg_helper functions.
> >
> > Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> 
> 
> No, you don't want to discriminately change every call.  That was my original
> point about not needing to change seg_helper.c or smm_helper.c.
> 
> Further, any such changes would go along with the changes in translate.c to
> remove the state saving there.
> 
> I would only change those that are "normal" memory operations, like fp loads
> etc.  The segmentation changes are rare.  The task state helpers require state
> saving anyway, so requiring a TCG search is a pessimization.

Then we'll have to stop the translation after every instruction that uses these function.
Is this a limited subset?

Pavel Dovgalyuk