From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33642)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1ZC5jj-0002ky-SQ
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:43:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1ZC5jg-0001gv-BA
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:43:03 -0400
Received: from mail.ispras.ru ([83.149.199.45]:60610)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1ZC5jf-0001gD-Uz
	for qemu-devel@nongnu.org; Mon, 06 Jul 2015 08:43:00 -0400
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <20150706082535.11980.88013.stgit@PASHA-ISP>
	<20150706082605.11980.53159.stgit@PASHA-ISP>
	<559A6EB9.5050005@twiddle.net>
In-Reply-To: <559A6EB9.5050005@twiddle.net>
Date: Mon, 6 Jul 2015 15:42:58 +0300
Message-ID: <001701d0b7e9$4a1c8370$de558a50$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [PATCH v5 05/11] target-i386: exception handling
	for FPU instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Richard Henderson' <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, rth7680@gmail.com, leon.alrae@imgtec.com, agraf@suse.de, aurelien@aurel32.net

> From: Richard Henderson [mailto:rth7680@gmail.com] On Behalf Of Richard Henderson
> On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
> > @@ -1117,33 +1131,33 @@ void helper_fxsave(CPUX86State *env, target_ulong ptr, int data64)
> >       for (i = 0; i < 8; i++) {
> >           fptag |= (env->fptags[i] << i);
> >       }
> > -    cpu_stw_data(env, ptr, env->fpuc);
> > -    cpu_stw_data(env, ptr + 2, fpus);
> > -    cpu_stw_data(env, ptr + 4, fptag ^ 0xff);
> > +    cpu_stw_data_ra(env, ptr, env->fpuc, GETPC());
> > +    cpu_stw_data_ra(env, ptr + 2, fpus, GETPC());
> > +    cpu_stw_data_ra(env, ptr + 4, fptag ^ 0xff, GETPC());
> 
> helper_fxsave and helper_fxrstor ought to have do_* versions just like you did
> for fstenv/fldenv.  (I'm working on a patch set that adds xsave/xrstor support
> and I'll need to re-use these functions.)

Why do_* functions should be in this series?
These changes will look orphaned.

Pavel Dovgalyuk