From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, stefanha@redhat.com, famz@redhat.com,
kwolf@redhat.com
Subject: Re: [Qemu-devel] Bottom halves VS timers
Date: Tue, 22 Jan 2019 14:31:25 +0300 [thread overview]
Message-ID: <001701d4b246$02928a80$07b79f80$@ru> (raw)
In-Reply-To: <bf5401c8-20b3-6774-fd9e-56ffe25e7431@redhat.com>
> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> On 22/01/19 08:15, Pavel Dovgalyuk wrote:
> > Scheduling new BH does not create a signal for the vCPU to suspend the
> > execution and process the main loop events (in record/replay we
> > synchronize these two threads).
>
> I think the bug is that in rr mode it should do so and cause a cpu_exit.
Right. I combined adding cpu_exit (into our private version) and increasing
an icount command-line parameter.
> If replace these bottom halves with timers, other bottom halves from
> the block layer may have the same issue; if you replace _all_ bottom
> halves with timers you have performance issues because bottom halves try
> very hard to avoid locks.
I see.
> Unfortunately this is getting really ugly... Basically, rr is
> reintroducing all the complications with iothread_requesting_mutex that
> were removed with mtTCG.
True. There are too many non-synchronized entities: bottom halves,
worker threads, iothreads, timers...
But RR is only possible when we have kind of synchronization objects for them.
Pavel Dovgalyuk
prev parent reply other threads:[~2019-01-22 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 7:15 [Qemu-devel] Bottom halves VS timers Pavel Dovgalyuk
2019-01-22 8:49 ` Paolo Bonzini
2019-01-22 11:31 ` Pavel Dovgalyuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001701d4b246$02928a80$07b79f80$@ru' \
--to=dovgaluk@ispras.ru \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).