From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46612)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dovgaluk@ispras.ru>) id 1bIDqv-0006E9-HQ
	for qemu-devel@nongnu.org; Wed, 29 Jun 2016 07:40:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dovgaluk@ispras.ru>) id 1bIDqp-0000i6-Hx
	for qemu-devel@nongnu.org; Wed, 29 Jun 2016 07:40:20 -0400
Received: from mail.ispras.ru ([83.149.199.45]:44907)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dovgaluk@ispras.ru>) id 1bIDqp-0000db-9x
	for qemu-devel@nongnu.org; Wed, 29 Jun 2016 07:40:15 -0400
From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
References: <20160608051352.1688.7877.stgit@PASHA-ISP>
	<20160608051404.1688.65453.stgit@PASHA-ISP>
	<257976361.20784345.1465381879882.JavaMail.zimbra@redhat.com>
	<001201d1cabc$b1b003e0$15100ba0$@ru>
	<bb3d82c5-f018-e101-9760-969cfff629df@redhat.com>
In-Reply-To: <bb3d82c5-f018-e101-9760-969cfff629df@redhat.com>
Date: Wed, 29 Jun 2016 14:40:05 +0300
Message-ID: <001801d1d1fa$fb66e9f0$f234bdd0$@ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [PATCH 2/3] replay: allow replay stopping and
 restarting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Paolo Bonzini' <pbonzini@redhat.com>, 'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>
Cc: jasowang@redhat.com, david@gibson.dropbear.id.au, qemu-devel@nongnu.org, agraf@suse.de

> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini
> On 20/06/2016 08:26, Pavel Dovgalyuk wrote:
> >> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> >>> From: "Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>
> >>> This patch fixes bug with stopping and restarting replay
> >>> through monitor.
> >>>
> >>> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> >>> ---
> >
> >> I think that you want to call
> >> replay_disable_events...
> >>
> >>>      bdrv_drain_all();
> >>
> >> ... after this bdrv_drain_all.
> >
> > Why? We disable replay events to avoid adding new block requests
> > to the queue. How this is related to drain all?
> 
> drain all completes the guest's pending requests.  If you disable events
> before drain all, doesn't that cause a mismatch between record and replay?

Looks reasonable, thanks. I'll update the patch.
What about replay patch for networking?

Pavel Dovgalyuk