From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:45645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gt4EI-0006he-2y for qemu-devel@nongnu.org; Mon, 11 Feb 2019 00:34:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gt4EH-0007v2-7W for qemu-devel@nongnu.org; Mon, 11 Feb 2019 00:34:06 -0500 Received: from mail.ispras.ru ([83.149.199.45]:45594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gt4EG-0007tN-V1 for qemu-devel@nongnu.org; Mon, 11 Feb 2019 00:34:05 -0500 From: "Pavel Dovgalyuk" References: <154937205518.29984.9188603364499998604.stgit@pasha-VirtualBox> In-Reply-To: <154937205518.29984.9188603364499998604.stgit@pasha-VirtualBox> Date: Mon, 11 Feb 2019 08:34:02 +0300 Message-ID: <001c01d4c1cb$65a26390$30e72ab0$@ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH] mips: implement qmp query-cpu-definitions command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Pavel Dovgalyuk' , qemu-devel@nongnu.org Cc: arikalo@wavecomp.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, natalia.fursova@ispras.ru, eblake@redhat.com, aurelien@aurel32.net Ping. Pavel Dovgalyuk > -----Original Message----- > From: Pavel Dovgalyuk [mailto:Pavel.Dovgaluk@ispras.ru] > Sent: Tuesday, February 05, 2019 4:08 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovgaluk@ispras.ru; arikalo@wavecomp.com; mdroth@linux.vnet.ibm.com; > armbru@redhat.com; dovgaluk@ispras.ru; natalia.fursova@ispras.ru; eblake@redhat.com; > aurelien@aurel32.net > Subject: [PATCH] mips: implement qmp query-cpu-definitions command > > This patch enables QMP-based querying of the available CPU types for MIPS > and MIPS64 platforms. > > Signed-off-by: Pavel Dovgalyuk > --- > monitor.c | 2 +- > target/mips/helper.c | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/monitor.c b/monitor.c > index c09fa63940..25d3b141ad 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1165,7 +1165,7 @@ static void qmp_unregister_commands_hack(void) > qmp_unregister_command(&qmp_commands, "query-cpu-model-comparison"); > #endif > #if !defined(TARGET_PPC) && !defined(TARGET_ARM) && !defined(TARGET_I386) \ > - && !defined(TARGET_S390X) > + && !defined(TARGET_S390X) && !defined(TARGET_MIPS) > qmp_unregister_command(&qmp_commands, "query-cpu-definitions"); > #endif > } > diff --git a/target/mips/helper.c b/target/mips/helper.c > index 8988452dbd..c84d056c09 100644 > --- a/target/mips/helper.c > +++ b/target/mips/helper.c > @@ -24,6 +24,7 @@ > #include "exec/cpu_ldst.h" > #include "exec/log.h" > #include "hw/mips/cpudevs.h" > +#include "sysemu/arch_init.h" > > enum { > TLBRET_XI = -6, > @@ -1472,3 +1473,35 @@ void QEMU_NORETURN do_raise_exception_err(CPUMIPSState *env, > > cpu_loop_exit_restore(cs, pc); > } > + > +static void mips_cpu_add_definition(gpointer data, gpointer user_data) > +{ > + ObjectClass *oc = data; > + CpuDefinitionInfoList **cpu_list = user_data; > + CpuDefinitionInfoList *entry; > + CpuDefinitionInfo *info; > + const char *typename; > + > + typename = object_class_get_name(oc); > + info = g_malloc0(sizeof(*info)); > + info->name = g_strndup(typename, > + strlen(typename) - strlen("-" TYPE_MIPS_CPU)); > + info->q_typename = g_strdup(typename); > + > + entry = g_malloc0(sizeof(*entry)); > + entry->value = info; > + entry->next = *cpu_list; > + *cpu_list = entry; > +} > + > +CpuDefinitionInfoList *arch_query_cpu_definitions(Error **errp) > +{ > + CpuDefinitionInfoList *cpu_list = NULL; > + GSList *list; > + > + list = object_class_get_list(TYPE_MIPS_CPU, false); > + g_slist_foreach(list, mips_cpu_add_definition, &cpu_list); > + g_slist_free(list); > + > + return cpu_list; > +}