qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Sebastian Herbszt" <herbszt@gmx.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Re: [ANN] Bochs bios ported to gcc
Date: Sat, 5 Apr 2008 22:20:04 +0200	[thread overview]
Message-ID: <002301c8975a$8d4f89b0$0201a8c0@zeug> (raw)
In-Reply-To: 20080405180336.GA9598@ohio.lan

> On Sat, Apr 05, 2008 at 03:14:14PM +0200, Sebastian Herbszt wrote:
>>>> Thanks for this work. I noticed the "F12" key to choose device to 
>>>> boot
>>>> from is missing from your bios, compared to the lastest qemu 
>>>> snapshot.
>>>> Any plan to include it soon ?
>>>
>>> Hrmm.  I don't see the source code for it.  The feature is not in
>>> bochs cvs, and I don't see a patch in the qemu svn.
>>>
>>> Any ideas on where the code came from?
>>
>> bochs cvs, bios/rombios.c -  Revision 1.202
>> - BIOS boot menu support added (SF patch #1901027 by Sebastian)
>> http://bochs.cvs.sourceforge.net/bochs/bochs/bios/rombios.c?view=log
>
> Sorry, I somehow missed that.
>
> Sure, I'll port the feature over.

I just took at look at your legacybios and you already ported it.

> Sebastian, should the menu be in the boot code instead of the post
> code?

It looks ok to split it between your post.c and boot.c. Though it might
be a little misleading to put interactive_bootmenu() in post_menu.c.
Maybe move it to boot_menu.c?

- Sebastian

      reply	other threads:[~2008-04-05 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02  1:46 [Qemu-devel] [ANN] Bochs bios ported to gcc Kevin O'Connor
2008-04-04  7:45 ` Christian MICHON
2008-04-05  4:48   ` Kevin O'Connor
2008-04-05 13:14     ` [Qemu-devel] " Sebastian Herbszt
2008-04-05 18:03       ` Kevin O'Connor
2008-04-05 20:20         ` Sebastian Herbszt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002301c8975a$8d4f89b0$0201a8c0@zeug' \
    --to=herbszt@gmx.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).