From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JiEsk-0002cT-Pp
	for qemu-devel@nongnu.org; Sat, 05 Apr 2008 16:20:58 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JiEsj-0002cF-AQ
	for qemu-devel@nongnu.org; Sat, 05 Apr 2008 16:20:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JiEsj-0002cC-54
	for qemu-devel@nongnu.org; Sat, 05 Apr 2008 16:20:57 -0400
Received: from mail.gmx.net ([213.165.64.20])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <herbszt@gmx.de>) id 1JiEsi-0001CL-Tw
	for qemu-devel@nongnu.org; Sat, 05 Apr 2008 16:20:57 -0400
Message-ID: <002301c8975a$8d4f89b0$0201a8c0@zeug>
From: "Sebastian Herbszt" <herbszt@gmx.de>
References: <20080405044807.GA4049@ohio.lan><005201c8971f$0cc4bee0$0201a8c0@zeug>
	<20080405180336.GA9598@ohio.lan>
Date: Sat, 5 Apr 2008 22:20:04 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Re: [ANN] Bochs bios ported to gcc
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> On Sat, Apr 05, 2008 at 03:14:14PM +0200, Sebastian Herbszt wrote:
>>>> Thanks for this work. I noticed the "F12" key to choose device to 
>>>> boot
>>>> from is missing from your bios, compared to the lastest qemu 
>>>> snapshot.
>>>> Any plan to include it soon ?
>>>
>>> Hrmm.  I don't see the source code for it.  The feature is not in
>>> bochs cvs, and I don't see a patch in the qemu svn.
>>>
>>> Any ideas on where the code came from?
>>
>> bochs cvs, bios/rombios.c -  Revision 1.202
>> - BIOS boot menu support added (SF patch #1901027 by Sebastian)
>> http://bochs.cvs.sourceforge.net/bochs/bochs/bios/rombios.c?view=log
>
> Sorry, I somehow missed that.
>
> Sure, I'll port the feature over.

I just took at look at your legacybios and you already ported it.

> Sebastian, should the menu be in the boot code instead of the post
> code?

It looks ok to split it between your post.c and boot.c. Though it might
be a little misleading to put interactive_bootmenu() in post_menu.c.
Maybe move it to boot_menu.c?

- Sebastian