From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Paolo Bonzini' <pbonzini@redhat.com>,
'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jasowang@redhat.com,
quintela@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 4/8] replay: save/load initial state
Date: Tue, 20 Sep 2016 15:39:57 +0300 [thread overview]
Message-ID: <002301d2133c$18cbf170$4a63d450$@ru> (raw)
In-Reply-To: <85a6ea4b-880c-cb06-edc1-af19b480ccd3@redhat.com>
> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> On 20/09/2016 14:31, Pavel Dovgalyuk wrote:
> > @@ -291,6 +292,8 @@ void replay_configure(QemuOpts *opts)
> > exit(1);
> > }
> >
> > + replay_snapshot = g_strdup(qemu_opt_get(opts, "rrsnapshot"));
> > +
> > replay_enable(fname, mode);
> >
>
> Should you set snapshot = 1 here if there is no rrsnapshot option?
No, because there is default snapshot name for the case when user
specifies overlay for the drives.
Pavel Dovgalyuk
next prev parent reply other threads:[~2016-09-20 12:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 12:31 [Qemu-devel] [PATCH v3 0/8] replay additions Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 1/8] record/replay: add network support Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 2/8] block: set snapshot option for block devices in blkreplay module Pavel Dovgalyuk
2016-09-20 12:35 ` Paolo Bonzini
2016-09-20 12:43 ` Pavel Dovgalyuk
2016-09-20 12:57 ` Paolo Bonzini
2016-09-20 14:28 ` Kevin Wolf
2016-09-20 15:11 ` Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 3/8] block: don't make snapshots for filters Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 4/8] replay: save/load initial state Pavel Dovgalyuk
2016-09-20 12:37 ` Paolo Bonzini
2016-09-20 12:39 ` Pavel Dovgalyuk [this message]
2016-09-20 12:52 ` Paolo Bonzini
2016-09-20 13:37 ` Pavel Dovgalyuk
2016-09-20 13:45 ` Paolo Bonzini
2016-09-20 13:51 ` Pavel Dovgalyuk
2016-09-20 13:53 ` Paolo Bonzini
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 5/8] replay: move internal data to the structure Pavel Dovgalyuk
2016-09-20 12:32 ` [Qemu-devel] [PATCH v3 6/8] replay: vmstate for replay module Pavel Dovgalyuk
2016-09-20 12:32 ` [Qemu-devel] [PATCH v3 7/8] replay: allow replay stopping and restarting Pavel Dovgalyuk
2016-09-20 12:32 ` [Qemu-devel] [PATCH v3 8/8] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2016-09-20 13:35 ` [Qemu-devel] [PATCH v3 0/8] replay additions no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002301d2133c$18cbf170$4a63d450$@ru' \
--to=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).