From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dovgaluk@ispras.ru>) id 1bmKLK-0002z0-Ml
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:40:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dovgaluk@ispras.ru>) id 1bmKLG-0005MS-Eg
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:40:10 -0400
Received: from mail.ispras.ru ([83.149.199.45]:58528)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dovgaluk@ispras.ru>) id 1bmKLG-0005G1-7G
	for qemu-devel@nongnu.org; Tue, 20 Sep 2016 08:40:06 -0400
From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
References: <20160920123126.5400.29283.stgit@PASHA-ISP.def.inno>
	<20160920123149.5400.87854.stgit@PASHA-ISP.def.inno>
	<85a6ea4b-880c-cb06-edc1-af19b480ccd3@redhat.com>
In-Reply-To: <85a6ea4b-880c-cb06-edc1-af19b480ccd3@redhat.com>
Date: Tue, 20 Sep 2016 15:39:57 +0300
Message-ID: <002301d2133c$18cbf170$4a63d450$@ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [PATCH v3 4/8] replay: save/load initial state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Paolo Bonzini' <pbonzini@redhat.com>, 'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jasowang@redhat.com, quintela@redhat.com, mst@redhat.com

> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> On 20/09/2016 14:31, Pavel Dovgalyuk wrote:
> > @@ -291,6 +292,8 @@ void replay_configure(QemuOpts *opts)
> >          exit(1);
> >      }
> >
> > +    replay_snapshot = g_strdup(qemu_opt_get(opts, "rrsnapshot"));
> > +
> >      replay_enable(fname, mode);
> >
> 
> Should you set snapshot = 1 here if there is no rrsnapshot option?

No, because there is default snapshot name for the case when user 
specifies overlay for the drives.

Pavel Dovgalyuk