From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMc9N-0000fa-2v for qemu-devel@nongnu.org; Wed, 27 Aug 2014 08:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMc9F-0008Fj-L1 for qemu-devel@nongnu.org; Wed, 27 Aug 2014 08:16:29 -0400 Received: from mail.ispras.ru ([83.149.199.45]:39599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMc9F-0008Eh-Cx for qemu-devel@nongnu.org; Wed, 27 Aug 2014 08:16:21 -0400 From: "Pavel Dovgaluk" References: <20140826071427.1672.48119.stgit@PASHA-ISP> <20140826071503.1672.32964.stgit@PASHA-ISP> <53FC5ADE.8030306@redhat.com> In-Reply-To: <53FC5ADE.8030306@redhat.com> Date: Wed, 27 Aug 2014 16:16:19 +0400 Message-ID: <002401cfc1f0$b5aefe50$210cfaf0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru > From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini > Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > > vapic state should not be synchronized with APIC while loading, > > because APIC state could be not loaded yet at that moment. > > We just save vapic_paddr in APIC VMState instead of synchronization. > > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer > with expiration time in the past (e.g. at time zero) to run the sync > code as soon as possible? Then you can preserve the current migration > format and avoid using the invalid APIC state. Does this method guarantee, that nobody (like other timers) will access APIC between loading the vmstate and invocation of the timer? Pavel Dovgalyuk