From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBhdY-0007SS-RR for qemu-devel@nongnu.org; Mon, 28 Jul 2014 05:54:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBhdS-0007vt-MN for qemu-devel@nongnu.org; Mon, 28 Jul 2014 05:54:32 -0400 Received: from mail.ispras.ru ([83.149.199.45]:44798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBhdR-0007v8-5A for qemu-devel@nongnu.org; Mon, 28 Jul 2014 05:54:26 -0400 From: "Pavel Dovgaluk" References: <20140717110153.8352.80175.stgit@PASHA-ISP> <20140717110255.8352.73575.stgit@PASHA-ISP> <53D61AE3.6000700@redhat.com> In-Reply-To: <53D61AE3.6000700@redhat.com> Date: Mon, 28 Jul 2014 13:54:23 +0400 Message-ID: <002601cfaa49$e974bc70$bc5e3550$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v2 10/49] rtl8139: adding new fields to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini > Il 17/07/2014 13:02, Pavel Dovgalyuk ha scritto: > > This patch adds virtual clock-dependent timers to VMState to allow correct > > saving and restoring the state of RTL8139 network controller. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > hw/net/rtl8139.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c > > index 90bc5ec..992caf0 100644 > > --- a/hw/net/rtl8139.c > > +++ b/hw/net/rtl8139.c > > @@ -3289,7 +3289,7 @@ static void rtl8139_pre_save(void *opaque) > > > > static const VMStateDescription vmstate_rtl8139 = { > > .name = "rtl8139", > > - .version_id = 4, > > + .version_id = 5, > > .minimum_version_id = 3, > > .post_load = rtl8139_post_load, > > .pre_save = rtl8139_pre_save, > > @@ -3363,6 +3363,9 @@ static const VMStateDescription vmstate_rtl8139 = { > > VMSTATE_STRUCT(tally_counters, RTL8139State, 0, > > vmstate_tally_counters, RTL8139TallyCounters), > > > > + VMSTATE_TIMER_V(timer, RTL8139State, 5), > > timer need not be migrated, because it is reinstated by rtl8139_post_load. > That's true for normal execution. In replay execution mode post_load can be called before cached virtual clock values are loaded. This may cause invalid setting of the timer and raising an IRQ which didn't happen in record mode. I will update this patch to fix post_load function and avoid this non-deterministic behavior. Pavel Dovgalyuk