From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xosmg-0005yR-63 for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:42:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xosma-0006dS-5j for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:41:54 -0500 Received: from mail.ispras.ru ([83.149.199.45]:60218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XosmZ-0006cw-Ua for qemu-devel@nongnu.org; Thu, 13 Nov 2014 06:41:48 -0500 From: "Pavel Dovgaluk" References: <20141107103123.6136.18545.stgit@PASHA-ISP> <20141107103201.6136.89187.stgit@PASHA-ISP> <54634C72.8060806@redhat.com> In-Reply-To: <54634C72.8060806@redhat.com> Date: Thu, 13 Nov 2014 14:41:49 +0300 Message-ID: <002701cfff36$cfa41e70$6eec5b50$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v4 06/25] cpu-exec: reset exception_index correctly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini > On 07/11/2014 11:32, Pavel Dovgalyuk wrote: > > Exception index is reset at every entry at every entry into cpu_exec() > > function. This may cause missing the exceptions while replaying them. > > This patch moves exception_index reset to the locations where they are > > processed. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > cpu-exec.c | 2 +- > > cpus.c | 1 + > > 2 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/cpu-exec.c b/cpu-exec.c > > index 8830255..011f51f 100644 > > --- a/cpu-exec.c > > +++ b/cpu-exec.c > > @@ -358,7 +358,6 @@ int cpu_exec(CPUArchState *env) > > } > > > > cc->cpu_exec_enter(cpu); > > - cpu->exception_index = -1; > > > > /* Calculate difference between guest clock and host clock. > > * This delay includes the delay of the last cycle, so > > @@ -378,6 +377,7 @@ int cpu_exec(CPUArchState *env) > > if (ret == EXCP_DEBUG) { > > cpu_handle_debug_exception(env); > > } > > + cpu->exception_index = -1; > > break; > > } else { > > #if defined(CONFIG_USER_ONLY) > > diff --git a/cpus.c b/cpus.c > > index e53d605..7e8c507 100644 > > --- a/cpus.c > > +++ b/cpus.c > > @@ -1016,6 +1016,7 @@ static void *qemu_tcg_cpu_thread_fn(void *arg) > > CPU_FOREACH(cpu) { > > cpu->thread_id = qemu_get_thread_id(); > > cpu->created = true; > > + cpu->exception_index = -1; > > } > > qemu_cond_signal(&qemu_cpu_cond); > > > > > > > > > > What about user-mode emulation? Do you need to reset > cpu->exception_index for it too? Thank you, I missed that. Pavel Dovgalyuk