From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Kevin Wolf' <kwolf@redhat.com>,
'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] block: implement bdrv_snapshot_goto for blkreplay
Date: Mon, 27 Feb 2017 15:07:35 +0300 [thread overview]
Message-ID: <002701d290f2$1541b9c0$3fc52d40$@ru> (raw)
In-Reply-To: <20170222100543.GC4112@noname.str.redhat.com>
> From: Kevin Wolf [mailto:kwolf@redhat.com]
> Am 31.01.2017 um 12:57 hat Pavel Dovgalyuk geschrieben:
> > This patch enables making snapshots with blkreplay used in
> > block devices.
> >
> > Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
>
> Specifically, I think it avoids the blkreplay_open/close sequence. Is
> this what is needed to make it work?
Then I'll need to implement bdrv_open, because there is only bdrv_file_open
for blkreplay now.
Which way is better?
> We should probably mention in the commit message the exact reason why
> implementing .bdrv_snapshot_goto, but not the other snapshot related
> callbacks, fixes things. If you confirm my assumption, I can add that
> while applying.
Pavel Dovgalyuk
next prev parent reply other threads:[~2017-02-27 12:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 11:57 [Qemu-devel] [PATCH 0/3] block devices record/replay update Pavel Dovgalyuk
2017-01-31 11:57 ` [Qemu-devel] [PATCH 1/3] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-02-22 10:05 ` Kevin Wolf
2017-02-27 12:07 ` Pavel Dovgalyuk [this message]
2017-02-27 17:35 ` Kevin Wolf
2017-01-31 11:57 ` [Qemu-devel] [PATCH 2/3] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-02-22 10:24 ` Kevin Wolf
2017-01-31 11:57 ` [Qemu-devel] [PATCH 3/3] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2017-02-22 10:28 ` Kevin Wolf
2017-02-13 5:04 ` [Qemu-devel] [PATCH 0/3] block devices record/replay update Pavel Dovgalyuk
2017-02-20 5:36 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002701d290f2$1541b9c0$3fc52d40$@ru' \
--to=dovgaluk@ispras.ru \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).