From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53085)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1T6Fnc-0004rT-Q5
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 03:01:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1T6FnY-000194-BJ
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 03:01:20 -0400
Received: from mail.ispras.ru ([83.149.199.43]:40865)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1T6FnY-00018x-3i
	for qemu-devel@nongnu.org; Tue, 28 Aug 2012 03:01:16 -0400
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <503b6650.c88ddc0a.7e15.ffffb689SMTPIN_ADDED@mx.google.com>
	<CAFEAcA-ftZhoy4VO9qdVHfb_7Gvk82VspAqXmV9iegjw_d3tJw@mail.gmail.com>
In-Reply-To: <CAFEAcA-ftZhoy4VO9qdVHfb_7Gvk82VspAqXmV9iegjw_d3tJw@mail.gmail.com>
Date: Tue, 28 Aug 2012 11:01:15 +0400
Message-ID: <002801cd84ea$ea756bf0$bf6043d0$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [PATCH] Save/load PC speaker internal state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Peter Maydell' <peter.maydell@linaro.org>, 'Jan Kiszka' <jan.kiszka@siemens.com>
Cc: 'qemu-devel' <qemu-devel@nongnu.org>

> -----Original Message-----
> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> Sent: Monday, August 27, 2012 4:50 PM
> To: Pavel Dovgaluk
> Cc: qemu-devel
> Subject: Re: [Qemu-devel] [PATCH] Save/load PC speaker internal state
> 
> On 27 August 2012 13:21, Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru> wrote:
> > Save PC speaker state to remove differences between system
> > states after saving the snapshot and after loading it again.
> > This patch is needed for deterministic replay of the execution.
> >
> > Signed-off-by: Pavel Dovgalyuk<pavel.dovgaluk@gmail.com>
> 
> Hi Pavel; thanks for this patch. Couple of minor issues:
> 
> > +static const VMStateDescription vmstate_spk = {
> > +    .name = "pcspk",
> > +    .version_id = 1,
> > +    .minimum_version_id = 1,
> > +    .minimum_version_id_old = 1,
> > +    .fields      = (VMStateField[]) {
> > +        VMSTATE_UINT8_ARRAY(sample_buf, PCSpkState, PCSPK_BUF_LEN),
> > +        VMSTATE_UINT32(pit_count, PCSpkState),
> > +        VMSTATE_UINT32(samples, PCSpkState),
> > +        VMSTATE_UINT32(play_pos, PCSpkState),
> > +        VMSTATE_INT32(data_on, PCSpkState),
> > +        VMSTATE_INT32(dummy_refresh_clock, PCSpkState),
> 
> I think that you need also to update the types in the PCSpkState
> struct from int/unsigned int to int32_t/uint32_t, otherwise this
> won't compile on a 64 bit system.

  Peter, Jan, thank you for the reviews. I've sent new version of the patch.

Pavel Dovgaluk