From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
To: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru
Subject: Re: [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate
Date: Wed, 27 Aug 2014 17:03:30 +0400 [thread overview]
Message-ID: <002b01cfc1f7$4c954e90$e5bfebb0$@Dovgaluk@ispras.ru> (raw)
In-Reply-To: <53FDD09C.4040208@redhat.com>
> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> Il 27/08/2014 14:16, Pavel Dovgaluk ha scritto:
> >> > Can you use a vm_change_state_handler, or a QEMU_CLOCK_VIRTUAL timer
> >> > with expiration time in the past (e.g. at time zero) to run the sync
> >> > code as soon as possible? Then you can preserve the current migration
> >> > format and avoid using the invalid APIC state.
> > Does this method guarantee, that nobody (like other timers) will access
> > APIC between loading the vmstate and invocation of the timer?
>
> Hmm, probably not. The bug would not be other timers accessing the
> APIC, because that would also call apic_sync_vapic and the only effect
> would be an extra useless synchronization. The bug would happen if the
> APIC is accessed by the CPU before the timer has the occasion to run.
Sorry, but I don't understand which problem we will solve with apic_sync_vapic.
All fields that were added to vmstate are not affected by this function.
Could you explain your idea?
Pavel Dovgalyuk
next prev parent reply other threads:[~2014-08-27 13:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 7:14 [Qemu-devel] [PATCH 00/12] Fixing hardware migration issues Pavel Dovgalyuk
2014-08-26 7:14 ` [Qemu-devel] [PATCH 01/12] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2014-08-26 7:14 ` [Qemu-devel] [PATCH 02/12] pcspk: " Pavel Dovgalyuk
2014-08-26 9:10 ` Paolo Bonzini
2014-08-26 7:14 ` [Qemu-devel] [PATCH 03/12] fdc: " Pavel Dovgalyuk
2014-08-26 9:10 ` Paolo Bonzini
2014-08-26 7:14 ` [Qemu-devel] [PATCH 04/12] parallel: " Pavel Dovgalyuk
2014-08-26 9:10 ` Paolo Bonzini
2014-08-26 7:14 ` [Qemu-devel] [PATCH 05/12] serial: fixing " Pavel Dovgalyuk
2014-08-26 10:09 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate Pavel Dovgalyuk
2014-08-26 10:01 ` Paolo Bonzini
2014-08-27 12:16 ` Pavel Dovgaluk
2014-08-27 12:35 ` Paolo Bonzini
2014-08-27 13:03 ` Pavel Dovgaluk [this message]
2014-08-27 13:22 ` Paolo Bonzini
2014-09-09 10:30 ` Pavel Dovgaluk
2014-09-09 12:14 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 07/12] hpet: fixing saving and loading process Pavel Dovgalyuk
2014-08-26 7:15 ` [Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate Pavel Dovgalyuk
2014-08-26 9:12 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 09/12] rtl8139: " Pavel Dovgalyuk
2014-08-26 8:53 ` Paolo Bonzini
2014-08-27 10:15 ` Pavel Dovgaluk
2014-08-27 10:23 ` Paolo Bonzini
2014-08-27 10:30 ` Pavel Dovgaluk
2014-08-27 10:42 ` Paolo Bonzini
2014-08-27 10:48 ` Pavel Dovgaluk
[not found] ` <30591.5658282631$1409136551@news.gmane.org>
2014-08-27 15:50 ` Paolo Bonzini
2014-08-28 8:31 ` Pavel Dovgaluk
2014-08-28 11:02 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate Pavel Dovgalyuk
2014-08-26 9:21 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate Pavel Dovgalyuk
2014-08-26 8:58 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 12/12] pl031: " Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002b01cfc1f7$4c954e90$e5bfebb0$@Dovgaluk@ispras.ru' \
--to=pavel.dovgaluk@ispras.ru \
--cc=maria.klimushenkova@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zealot351@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).