qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: 'Paolo Bonzini' <pbonzini@redhat.com>,
	'Pavel Dovgalyuk' <pavel.dovgaluk@ispras.ru>,
	qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, jasowang@redhat.com,
	quintela@redhat.com, mst@redhat.com,
	'Kevin Wolf' <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/8] replay: save/load initial state
Date: Tue, 20 Sep 2016 16:51:15 +0300	[thread overview]
Message-ID: <002c01d21346$0e9fd540$2bdf7fc0$@ru> (raw)
In-Reply-To: <f80b8906-c7bf-f9a7-adf0-7d981eebbc9a@redhat.com>

> From: Paolo Bonzini [mailto:pbonzini@redhat.com]
> On 20/09/2016 15:37, Pavel Dovgalyuk wrote:
> >> c) no rrsnapshot implies -snapshot:
> >>    without overlay:
> >>       -drive file=disk.raw,if=none,id=img-direct
> >>       -drive driver=blkreplay,if=none,image=img-direct,id=img-blkreplay
> >>
> >>    with overlay:
> >>      -drive file=foo.qcow2,if=none,id=img-direct
> >>      -drive driver=blkreplay,if=none,image=img-direct,id=img-blkreplay
> >>      -icount ...,rrsnapshot=snapname
> >
> > But how record will create this overlay?
> > This method requires creating overlay manually, because backing file is
> > not specified at all.
> 
> You create it manually, or you just use a .qcow2 file to begin with for
> your image.  Then:
> 
> 1) if you specify no snapshot, a temporary .qcow2 file is created on top
> so data is not destroyed
> 
> 2) if you specify a snapshot, that snapshot is preserved (so you don't
> lose the base state even though the file changes)

Now I see.
This seems ok, but:
 - this approach adds some garbage to original disk image
 - won't work with raw images

Pavel Dovgalyuk

  reply	other threads:[~2016-09-20 13:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-20 12:31 [Qemu-devel] [PATCH v3 0/8] replay additions Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 1/8] record/replay: add network support Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 2/8] block: set snapshot option for block devices in blkreplay module Pavel Dovgalyuk
2016-09-20 12:35   ` Paolo Bonzini
2016-09-20 12:43     ` Pavel Dovgalyuk
2016-09-20 12:57       ` Paolo Bonzini
2016-09-20 14:28   ` Kevin Wolf
2016-09-20 15:11     ` Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 3/8] block: don't make snapshots for filters Pavel Dovgalyuk
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 4/8] replay: save/load initial state Pavel Dovgalyuk
2016-09-20 12:37   ` Paolo Bonzini
2016-09-20 12:39     ` Pavel Dovgalyuk
2016-09-20 12:52       ` Paolo Bonzini
2016-09-20 13:37         ` Pavel Dovgalyuk
2016-09-20 13:45           ` Paolo Bonzini
2016-09-20 13:51             ` Pavel Dovgalyuk [this message]
2016-09-20 13:53               ` Paolo Bonzini
2016-09-20 12:31 ` [Qemu-devel] [PATCH v3 5/8] replay: move internal data to the structure Pavel Dovgalyuk
2016-09-20 12:32 ` [Qemu-devel] [PATCH v3 6/8] replay: vmstate for replay module Pavel Dovgalyuk
2016-09-20 12:32 ` [Qemu-devel] [PATCH v3 7/8] replay: allow replay stopping and restarting Pavel Dovgalyuk
2016-09-20 12:32 ` [Qemu-devel] [PATCH v3 8/8] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2016-09-20 13:35 ` [Qemu-devel] [PATCH v3 0/8] replay additions no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002c01d21346$0e9fd540$2bdf7fc0$@ru' \
    --to=dovgaluk@ispras.ru \
    --cc=jasowang@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).