From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1ZjlA0-00074O-3x
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:37:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1Zjl9w-0007O7-07
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:37:20 -0400
Received: from mail.ispras.ru ([83.149.199.45]:40614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1Zjl9v-0007NV-Od
	for qemu-devel@nongnu.org; Wed, 07 Oct 2015 05:37:15 -0400
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <1444161658-15038-1-git-send-email-pbonzini@redhat.com>
	<1444161658-15038-4-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1444161658-15038-4-git-send-email-pbonzini@redhat.com>
Date: Wed, 7 Oct 2015 12:37:16 +0300
Message-ID: <002d01d100e3$c1180c90$434825b0$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [PATCH 3/4] why is runstate_is_running needed?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Paolo Bonzini' <pbonzini@redhat.com>, qemu-devel@nongnu.org

I checked this patch.
Let's leave it without runstate_is_running() call.
If it will be needed later, we'll find it out.

Pavel Dovgalyuk


> -----Original Message-----
> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini
> Sent: Tuesday, October 06, 2015 11:01 PM
> To: qemu-devel@nongnu.org
> Cc: pavel.dovgaluk@ispras.ru
> Subject: [PATCH 3/4] why is runstate_is_running needed?
> 
> It doesn't seem correct to call it for all checkpoints, but why
> is it right for timerlist_run_timers?
> ---
>  qemu-timer.c   | 9 +++------
>  stubs/replay.c | 5 -----
>  2 files changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/qemu-timer.c b/qemu-timer.c
> index 3c6e4c3..f16e422 100644
> --- a/qemu-timer.c
> +++ b/qemu-timer.c
> @@ -488,20 +488,17 @@ bool timerlist_run_timers(QEMUTimerList *timer_list)
>          break;
>      default:
>      case QEMU_CLOCK_VIRTUAL:
> -        if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> -            || !replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL)) {
> +        if (!replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL)) {
>              goto out;
>          }
>          break;
>      case QEMU_CLOCK_HOST:
> -        if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> -            || !replay_checkpoint(CHECKPOINT_CLOCK_HOST)) {
> +        if (!replay_checkpoint(CHECKPOINT_CLOCK_HOST)) {
>              goto out;
>          }
>          break;
>      case QEMU_CLOCK_VIRTUAL_RT:
> -        if ((replay_mode != REPLAY_MODE_NONE && !runstate_is_running())
> -            || !replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL_RT)) {
> +        if (!replay_checkpoint(CHECKPOINT_CLOCK_VIRTUAL_RT)) {
>              goto out;
>          }
>          break;
> diff --git a/stubs/replay.c b/stubs/replay.c
> index 71fa7d5..42d01b5 100755
> --- a/stubs/replay.c
> +++ b/stubs/replay.c
> @@ -22,11 +22,6 @@ bool replay_checkpoint(ReplayCheckpoint checkpoint)
>      return true;
>  }
> 
> -int runstate_is_running(void)
> -{
> -    abort();
> -}
> -
>  bool replay_events_enabled(void)
>  {
>      return false;
> --
> 2.5.0
>