qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Pavel Dovgalyuk" <dovgaluk@ispras.ru>
To: <qemu-devel@nongnu.org>, <pbonzini@redhat.com>, <rth@twiddle.net>,
	<ehabkost@redhat.com>, <quintela@redhat.com>,
	<dgilbert@redhat.com>
Subject: [Qemu-devel] i386: EFER vs 32-bit CPU
Date: Wed, 29 May 2019 14:26:39 +0300	[thread overview]
Message-ID: <003a01d51611$6251a2b0$26f4e810$@ru> (raw)

Hello!

 

I found this while debugging the inconsistent saved/restored state of the virtual machine.

 

i386 (32 bit) emulation uses this register (in wrmsr and in MMU fault processing).

But it does not included in VMState, because "efer" field is disabled with #ifdef TARGET_X86_64

 

I think that efer should be saved for i386 too, but how it should be made to preserve the backward
compatibility?

Should we add a section for i386, which duplicates efer, or just version_id of the main VMSD should
be updated?

 

Pavel Dovgalyuk

 


             reply	other threads:[~2019-05-29 11:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29 11:26 Pavel Dovgalyuk [this message]
2019-05-29 11:30 ` [Qemu-devel] i386: EFER vs 32-bit CPU Dr. David Alan Gilbert
2019-05-29 11:39   ` Paolo Bonzini
2019-05-29 11:53     ` Pavel Dovgalyuk
2019-05-29 12:36       ` Dr. David Alan Gilbert
2019-05-29 14:03         ` Pavel Dovgalyuk
2019-05-30  0:52 ` Peter Xu
2019-05-30  5:54   ` Pavel Dovgalyuk
2019-05-30  9:00     ` Peter Xu
2019-05-30  9:04       ` Peter Xu
2019-05-30 11:00 ` TeLeMan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003a01d51611$6251a2b0$26f4e810$@ru' \
    --to=dovgaluk@ispras.ru \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).