From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33431C28CC0 for ; Wed, 29 May 2019 11:27:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06DE520B1F for ; Wed, 29 May 2019 11:27:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06DE520B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ispras.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:52063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVwjv-0006Kh-Bd for qemu-devel@archiver.kernel.org; Wed, 29 May 2019 07:27:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVwjB-00063V-DM for qemu-devel@nongnu.org; Wed, 29 May 2019 07:26:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVwj9-0007OF-VY for qemu-devel@nongnu.org; Wed, 29 May 2019 07:26:41 -0400 Received: from mail.ispras.ru ([83.149.199.45]:47878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVwj9-0007CX-KE for qemu-devel@nongnu.org; Wed, 29 May 2019 07:26:39 -0400 Received: from PASHAISP (unknown [85.142.117.226]) by mail.ispras.ru (Postfix) with ESMTPSA id 1CEB5540089; Wed, 29 May 2019 14:26:36 +0300 (MSK) From: "Pavel Dovgalyuk" To: , , , , , Date: Wed, 29 May 2019 14:26:39 +0300 Message-ID: <003a01d51611$6251a2b0$26f4e810$@ru> MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdUWEWIIHtVTtE6DS5KeQtA2/pLkfw== Content-Language: ru X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 83.149.199.45 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: [Qemu-devel] i386: EFER vs 32-bit CPU X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hello! I found this while debugging the inconsistent saved/restored state of the virtual machine. i386 (32 bit) emulation uses this register (in wrmsr and in MMU fault processing). But it does not included in VMState, because "efer" field is disabled with #ifdef TARGET_X86_64 I think that efer should be saved for i386 too, but how it should be made to preserve the backward compatibility? Should we add a section for i386, which duplicates efer, or just version_id of the main VMSD should be updated? Pavel Dovgalyuk