From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEDTD-0007Q1-B5 for qemu-devel@nongnu.org; Thu, 22 Jan 2015 03:50:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEDT5-00049w-An for qemu-devel@nongnu.org; Thu, 22 Jan 2015 03:50:31 -0500 Received: from mail.ispras.ru ([83.149.199.45]:36240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEDT5-00049N-42 for qemu-devel@nongnu.org; Thu, 22 Jan 2015 03:50:23 -0500 From: "Pavel Dovgaluk" References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112120111.3504.51955.stgit@PASHA-ISP> <54B3BA70.3080408@redhat.com> <000401d02f11$88a9c000$99fd4000$@Dovgaluk@ispras.ru> <54B4E7F2.1040200@redhat.com> In-Reply-To: <54B4E7F2.1040200@redhat.com> Date: Thu, 22 Jan 2015 11:50:22 +0300 Message-ID: <003d01d03620$756cc3a0$60464ae0$@Dovgaluk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > On 13/01/2015 10:15, Pavel Dovgaluk wrote: > > The numbers have no meaning. They just have to be distinct in different places. > > This is easier to achieve if you give a name to each place. > > > Sorry, missed one thing. > > run_all is used to distinguish timers processed in AIO by calling of > timerlistgroup_run_timers function > > and in main loop by calling qemu_clock_run_all_timers. > > Should you instead distinguish which TimerListGroup is being run? Then > main loop would checkpoint once for every TimerListGroup (which means > twice). I checked that. We should distinguish only run_all_timers and all other calls. Distinguishing the TimerListGroups does not work - replay hangs. Pavel Dovgalyuk