From: Paul Durrant <xadimgnik@gmail.com>
To: "'Markus Armbruster'" <armbru@redhat.com>, <qemu-devel@nongnu.org>
Cc: 'Anthony Perard' <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
'Stefano Stabellini' <sstabellini@kernel.org>,
'Gerd Hoffmann' <kraxel@redhat.com>
Subject: RE: [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors
Date: Tue, 5 May 2020 14:59:56 +0100 [thread overview]
Message-ID: <004001d622e5$75fd2d70$61f78850$@xen.org> (raw)
In-Reply-To: <20200505101908.6207-3-armbru@redhat.com>
> -----Original Message-----
> From: Markus Armbruster <armbru@redhat.com>
> Sent: 05 May 2020 11:19
> To: qemu-devel@nongnu.org
> Cc: Stefano Stabellini <sstabellini@kernel.org>; Anthony Perard <anthony.perard@citrix.com>; Paul
> Durrant <paul@xen.org>; Gerd Hoffmann <kraxel@redhat.com>; xen-devel@lists.xenproject.org
> Subject: [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors
>
> usbback_portid_add() leaks the error when qdev_device_add() fails.
> Fix that. While there, use the error to improve the error message.
>
> The qemu_opts_from_qdict() similarly leaks on failure. But any
> failure there is a programming error. Pass &error_abort.
>
> Fixes: 816ac92ef769f9ffc534e49a1bb6177bddce7aa2
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Paul Durrant <paul@xen.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: xen-devel@lists.xenproject.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Paul Durrant <paul@xen.org>
next prev parent reply other threads:[~2020-05-05 14:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 10:18 [PATCH v2 00/10] More miscellaneous error handling fixes Markus Armbruster
2020-05-05 10:18 ` [PATCH v2 01/10] nvdimm: Plug memory leak in uuid property setter Markus Armbruster
2020-05-06 14:23 ` Shivaprasad G Bhat
2020-05-05 10:19 ` [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors Markus Armbruster
2020-05-05 13:59 ` Paul Durrant [this message]
2020-05-05 10:19 ` [PATCH v2 03/10] s390x/cpumodel: Fix harmless misuse of visit_check_struct() Markus Armbruster
2020-05-05 10:19 ` [PATCH v2 04/10] tests/migration: Tighten error checking Markus Armbruster
2020-05-05 10:37 ` Philippe Mathieu-Daudé
2020-05-05 10:19 ` [PATCH v2 05/10] error: Use error_reportf_err() where appropriate Markus Armbruster
2020-05-05 10:19 ` [PATCH v2 06/10] mips/malta: Fix create_cps() error handling Markus Armbruster
2020-05-05 10:41 ` Aleksandar Markovic
2020-05-05 10:19 ` [PATCH v2 07/10] mips/boston: Fix boston_mach_init() " Markus Armbruster
2020-05-05 10:40 ` Aleksandar Markovic
2020-05-05 10:19 ` [PATCH v2 08/10] mips/boston: Plug memory leak in boston_mach_init() Markus Armbruster
2020-05-05 10:39 ` Aleksandar Markovic
2020-05-05 10:19 ` [PATCH v2 09/10] arm/sabrelite: Consistently use &error_fatal in sabrelite_init() Markus Armbruster
2020-05-05 10:19 ` [PATCH v2 10/10] i386: Fix x86_cpu_load_model() error API violation Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004001d622e5$75fd2d70$61f78850$@xen.org' \
--to=xadimgnik@gmail.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).